Skip to content

rspamd: disable checks for authenticated users#3440

Merged
georglauterbach merged 3 commits intomasterfrom
rspamd/check-outbound
Aug 8, 2023
Merged

rspamd: disable checks for authenticated users#3440
georglauterbach merged 3 commits intomasterfrom
rspamd/check-outbound

Conversation

@georglauterbach
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach commented Jul 23, 2023

Description

Disable all checks for authenticated users. See #3323 (comment).

The reason my PR deviates from the changes proposed by @williamdes is that enabling SPF, DKIM and policy checks for outbound emails still does not make sense really (because DKIM is only evaluated for incoming mail (remember, inbound emails are checked, outbound emails are signed), the same goes for SPF, and the policies group is just a combination of both). So we just disable all checks and hence, we can remove the line about the re-writes.

@williamdes can you please verify this configuration for me?:) I will keep all checks enabled on my machine, and I cannot test it locally (simply lacking time).

Related to #3323

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@georglauterbach georglauterbach added kind/new feature A new feature is requested in this issue or implemeted with this PR area/features service/security/rspamd labels Jul 23, 2023
@georglauterbach georglauterbach added this to the v13.0.0 milestone Jul 23, 2023
@georglauterbach georglauterbach self-assigned this Jul 23, 2023
@georglauterbach
Copy link
Copy Markdown
Member Author

https://mcgrail.com seems to be unreachable at the moment, hence the CI failures.

Comment thread mailserver.env Outdated
Comment thread target/rspamd/local.d/settings.conf
williamdes added a commit to wdes/mails.wdes.eu that referenced this pull request Aug 7, 2023
Copy link
Copy Markdown
Contributor

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine in production !
See:
image

The score is 0 and there is no tokens in the list

casperklein
casperklein previously approved these changes Aug 7, 2023
@georglauterbach
Copy link
Copy Markdown
Member Author

Works fine in production !

Noice! Then I will merge this :D Thank you @williamdes for your feedback!

Co-authored-by: William Desportes <[email protected]>
@georglauterbach georglauterbach merged commit f28fce9 into master Aug 8, 2023
@georglauterbach georglauterbach deleted the rspamd/check-outbound branch August 8, 2023 08:43
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 8, 2023

Documentation preview for this PR is ready! 🎉

Built with commit: 6dd56f7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/features kind/new feature A new feature is requested in this issue or implemeted with this PR service/security/rspamd

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants