rspamd: disable checks for authenticated users#3440
Merged
georglauterbach merged 3 commits intomasterfrom Aug 8, 2023
Merged
Conversation
Member
Author
|
https://mcgrail.com seems to be unreachable at the moment, hence the CI failures. |
williamdes
reviewed
Jul 23, 2023
williamdes
reviewed
Jul 23, 2023
williamdes
added a commit
to wdes/mails.wdes.eu
that referenced
this pull request
Aug 7, 2023
williamdes
approved these changes
Aug 7, 2023
casperklein
previously approved these changes
Aug 7, 2023
Member
Author
Noice! Then I will merge this :D Thank you @williamdes for your feedback! |
Co-authored-by: William Desportes <[email protected]>
Contributor
|
Documentation preview for this PR is ready! 🎉 Built with commit: 6dd56f7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Disable all checks for authenticated users. See #3323 (comment).
The reason my PR deviates from the changes proposed by @williamdes is that enabling SPF, DKIM and policy checks for outbound emails still does not make sense really (because DKIM is only evaluated for incoming mail (remember, inbound emails are checked, outbound emails are signed), the same goes for SPF, and the
policiesgroup is just a combination of both). So we just disable all checks and hence, we can remove the line about the re-writes.@williamdes can you please verify this configuration for me?:) I will keep all checks enabled on my machine, and I cannot test it locally (simply lacking time).
Related to #3323
Type of change
Checklist:
docs/)