rspamd: fix DKIM signing for inbound emails#3439
Merged
georglauterbach merged 2 commits intomasterfrom Jul 28, 2023
Merged
Conversation
georglauterbach
added
service/security/rspamd
kind/bug/fix
georglauterbach
force-pushed
the
rspamd/dkim-fallback
branch
from
d760fb2 to
a0c97db
Compare
georglauterbach
force-pushed
the
rspamd/dkim-fallback
branch
from
a0c97db to
66ef97b
Compare
Member
Author
|
https://mcgrail.com seems to be unreachable at the moment, hence the CI failures. |
casperklein
approved these changes
Jul 25, 2023
1 task
ap-wtioit
reviewed
Jul 31, 2023
Contributor
There was a problem hiding this comment.
is there a reason 192.168.0.0/16 is not in local_networks when all others are?
Member
Author
There was a problem hiding this comment.
No, I just forgot 😂 Sorry. Can you provide a PR? I will do a follow-up.
Contributor
There was a problem hiding this comment.
will do. np. wanted to know because i had to verify the downstream merge.
Member
Author
There was a problem hiding this comment.
I See, thanks for catching! I will do the follow-up since there is another change I want to integrate.
7 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See #3433 (comment).
Inbound emails should not be signed by Rspamd. Moreover, messages delivered from local addresses should not be signed either for the reasons mentioned in the comment above.
CC @Codelica
Fixes #3433
Type of change
Checklist:
docs/)