docs: IPv6 config examples with content tabs#3436
Merged
polarathene merged 5 commits intomasterfrom Jul 20, 2023
Merged
Conversation
For added clarity, a user requested we document the example config snippets instead of only linking externally. Some content has been shuffled around and revised, the nginx-proxy comment link removed, content tabs for presentation all within a single example admonition.
polarathene
added
kind/improvement
Some additional context and revised wording. Admonitions given titles.
Member
Author
|
@AlperShal hopefully this is what you roughly had in mind 😅 If the content looks a bit too noisy, I could collapse the info and tip admonitions by default to compact the focus on what's important. |
|
This is even better than what I thought it should be. Thanks for the awesome work! Only thing I was going to say that there being too much information boxes but you already suggested some cool fix about that. Them being collapsed on default would make it much cleaner. |
polarathene
commented
Jul 20, 2023
Contributor
|
Documentation preview for this PR is ready! 🎉 Built with commit: 3d6c768 |
Member
Author
|
Ready for review, auto-merge is all set to go when another maintainer approves 👍 |
casperklein
approved these changes
Jul 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For added clarity, a user requested we document the example config snippets instead of only linking external references to them.
Some content has been shuffled around and revised, the
nginx-proxycomment link removed (replaced with simplernetworkssyntax, and same as typical user-defined network creation, reduced to a small tip ondefaultoverriding), content tabs for presentation all within a single example admonition.This is a follow-up to the rewrite of IPv6 docs I did recently at: #3244
Resolves: #3422
Type of change
Preview
Direct preview link to updated section: https://pullrequest-3436--dms-doc-previews.netlify.app/config/advanced/ipv6/#enable-proper-ipv6-support
Revised version
Prior version