Skip to content

Don't register _setup_spam_to_junk() when SMTP_ONLY=1#3385

Merged
casperklein merged 2 commits intodocker-mailserver:masterfrom
casperklein:spam-to-junk-fix
Jun 11, 2023
Merged

Don't register _setup_spam_to_junk() when SMTP_ONLY=1#3385
casperklein merged 2 commits intodocker-mailserver:masterfrom
casperklein:spam-to-junk-fix

Conversation

@casperklein
Copy link
Copy Markdown
Member

@casperklein casperklein commented Jun 9, 2023 •
edited
Loading

Description

When running DMS with SMTP_ONLY=1 and MOVE_SPAM_TO_JUNK=1 (default), the following errors occur:

mailserver  | [   INF   ]  Welcome to docker-mailserver 12.1.0
mailserver  | [   INF   ]  Checking configuration
mailserver  | [   INF   ]  Configuring mail server
mailserver  | /usr/local/bin/setup.d/security/misc.sh: line 255: /usr/lib/dovecot/sieve-global/after/spam_to_junk.sieve: No such file or directory
mailserver  | error: script not found.
mailserver  | sievec: Fatal: failed to compile sieve script '/usr/lib/dovecot/sieve-global/after/spam_to_junk.sieve'
mailserver  | chown: cannot access '/usr/lib/dovecot/sieve-global/after/spam_to_junk.sieve': No such file or directory
mailserver  | chown: cannot access '/usr/lib/dovecot/sieve-global/after/spam_to_junk.svbin': No such file or directory
mailserver  | [ WARNING ]  !! INSECURE !! SSL configured with plain text access - DO NOT USE FOR PRODUCTION DEPLOYMENT
mailserver  | [   INF   ]  Starting daemons
mailserver  | [   INF   ]  mail.example.com is up and running

This PR provides a fix for that.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein self-assigned this Jun 9, 2023
@casperklein casperklein added this to the v13.0.0 milestone Jun 9, 2023
@casperklein casperklein added area/scripts kind/bug/fix A fix (PR) for a confirmed bug labels Jun 9, 2023
@casperklein casperklein marked this pull request as ready for review June 9, 2023 22:33
@casperklein casperklein merged commit e0c7cd4 into docker-mailserver:master Jun 11, 2023
@casperklein casperklein deleted the spam-to-junk-fix branch June 11, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@georglauterbach georglauterbach georglauterbach approved these changes

@polarathene polarathene Awaiting requested review from polarathene

Assignees

@casperklein casperklein

Labels

area/scripts kind/bug/fix A fix (PR) for a confirmed bug

Projects

None yet

Milestone

v13.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@casperklein @georglauterbach