Skip to content

Change 'for' style#3368

Merged
georglauterbach merged 2 commits intodocker-mailserver:masterfrom
casperklein:change-for-style
May 26, 2023
Merged

Change 'for' style#3368
georglauterbach merged 2 commits intodocker-mailserver:masterfrom
casperklein:change-for-style

Conversation

@casperklein
Copy link
Copy Markdown
Member

Description

Change 'for' style from

for i in 1 2 3
do
  do_something
done
}

to

for i in 1 2 3; do
  do_something
done

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein added this to the v13.0.0 milestone May 26, 2023
@casperklein casperklein self-assigned this May 26, 2023
@casperklein casperklein marked this pull request as ready for review May 26, 2023 10:37
@casperklein
Copy link
Copy Markdown
Member Author

This test failed on the first run. IMO not related to the PR changes.

The test succeed after a re-run.

@georglauterbach georglauterbach merged commit 8bfe842 into docker-mailserver:master May 26, 2023
@casperklein casperklein deleted the change-for-style branch May 27, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants