Skip to content

Change 'function' style#3364

Merged
casperklein merged 1 commit intodocker-mailserver:masterfrom
casperklein:style-change-functions
May 25, 2023
Merged

Change 'function' style#3364
casperklein merged 1 commit intodocker-mailserver:masterfrom
casperklein:style-change-functions

Conversation

@casperklein
Copy link
Copy Markdown
Member

@casperklein casperklein commented May 25, 2023

Description

Change 'function' style from

function foo
{
  do_something
}

to

function foo() {
  do_something
}

This new style aligns with the style already used in our tests.

Planned follow up style changes:

  • while
  • until

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein self-assigned this May 25, 2023
@casperklein casperklein added this to the v13.0.0 milestone May 25, 2023
@casperklein casperklein marked this pull request as ready for review May 25, 2023 11:24
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@casperklein casperklein merged commit 37ca0f9 into docker-mailserver:master May 25, 2023
@casperklein casperklein deleted the style-change-functions branch May 25, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants