ci: fix ShellCheck linting for BATS tests#3347
Merged
georglauterbach merged 3 commits intomasterfrom May 23, 2023
Merged
Conversation
georglauterbach
added
area/ci
area/tests
kind/bug/fix
georglauterbach
changed the title
casperklein
approved these changes
May 23, 2023
Member
A short summary why it was broken (the reason) would have been nice. The new solution looks good, but also the previous one (haven't checked why it wasn't working). |
Member
Author
|
Sorry for the lack of explanation. The crux was: the directory containing the tests changed, and the linting script wasn't adjusted. This PR takes care of the directory problem and also of some minor code smells. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make
lint.shlint BATS tests again.Type of change
Checklist:
docs/)