Skip to content

scripts: remove unnecessary return 0 statements#3290

Merged
georglauterbach merged 3 commits intomasterfrom
scripts/remove-unnecessary-returns
Apr 29, 2023
Merged

scripts: remove unnecessary return 0 statements#3290
georglauterbach merged 3 commits intomasterfrom
scripts/remove-unnecessary-returns

Conversation

@georglauterbach
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach commented Apr 25, 2023

Description

See #3285 (comment).

Type of change

  • Improvement (non-breaking change that does improve existing functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@georglauterbach georglauterbach added area/scripts kind/improvement Improve an existing feature, configuration file or the documentation labels Apr 25, 2023
@georglauterbach georglauterbach added this to the v12.1.0 milestone Apr 25, 2023
@georglauterbach georglauterbach self-assigned this Apr 25, 2023
@georglauterbach georglauterbach enabled auto-merge (squash) April 25, 2023 12:32
@georglauterbach
Copy link
Copy Markdown
Member Author

georglauterbach commented Apr 29, 2023

Merging this because this is well-discussed and doesn't reall need any review TBH.

@georglauterbach georglauterbach merged commit b6261c7 into master Apr 29, 2023
@georglauterbach georglauterbach deleted the scripts/remove-unnecessary-returns branch April 29, 2023 08:55
@casperklein
Copy link
Copy Markdown
Member

casperklein commented Apr 29, 2023

I was too tired yesterday and wanted to review today. Did you leave the return 0 in function __log_unexpected_error on purpose?

@georglauterbach
Copy link
Copy Markdown
Member Author

georglauterbach commented Apr 29, 2023

I was too tired yesterday and wanted to review today. Did you leave the return 0 in function __log_unexpected_error on purpose?

Yes :) I plan on adding more stuff to errors.sh and wanted to then do this in one go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casperklein casperklein Awaiting requested review from casperklein

Assignees

@georglauterbach georglauterbach

Labels

area/scripts kind/improvement Improve an existing feature, configuration file or the documentation

Projects

None yet

Milestone

v12.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@georglauterbach @casperklein