scripts: fix setting SRS_EXCLUDE_DOMAINS during startup#3271
Merged
georglauterbach merged 1 commit intodocker-mailserver:masterfrom Apr 18, 2023
Merged
Conversation
georglauterbach
requested changes
Apr 18, 2023
Member
georglauterbach
left a comment
georglauterbach
left a comment
There was a problem hiding this comment.
Thank you very much for finding this bug - very much appreciated! ❤️
The solution you propose does seem to work, but the regular expression that sed was working with is strange to begin with. I have therefore proposed a cleaner and simpler solution that is coherent with the rest of the code.
georglauterbach
changed the title
SRS_EXCLUDE_DOMAINS during startup
7 tasks
jamebus
force-pushed
the
fix-srs-exclude-domains
branch
from
73bdd64 to
07a84af
Compare
georglauterbach
approved these changes
Apr 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
mailserver | sed: -e expression #1, char 302: invalid reference \1 on `s' command's RHSThe sed command has a syntax error preventing a reference from being created. There's also an errant "=" that would output.
This fixes the issue and allows SRS_EXCLUDE_DOMAINS to be set in the postsrsd configuration.
Type of change
Checklist:
docs/)