scripts: improve shutdown function by making PANIC_STRATEGY obsolete#3265
Merged
casperklein merged 10 commits intodocker-mailserver:masterfrom Apr 18, 2023
Merged
scripts: improve shutdown function by making PANIC_STRATEGY obsolete#3265casperklein merged 10 commits intodocker-mailserver:masterfrom
casperklein merged 10 commits intodocker-mailserver:masterfrom
Conversation
Member
georglauterbach
left a comment
There was a problem hiding this comment.
LGTM 👍🏼
Just one minor nitpick :)
casperklein
commented
Apr 16, 2023
georglauterbach
approved these changes
Apr 17, 2023
Member
georglauterbach
left a comment
There was a problem hiding this comment.
LGTM 👍🏼
A very fine addition, and something I did not think of - I learned someting new about Bash, and I'm very grateful for that ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the decision obsolete, if the function is called from a subshell or not.
Inspired from: https://cravencode.com/post/essentials/exit-shell-script-from-subshell/
History:
_shutdownwill continue when called in a subshell (causing UB) #3140Type of change
Checklist:
docs/)