scripts: get all policyd-spf setup in one place#3263
Merged
georglauterbach merged 2 commits intomasterfrom Apr 14, 2023
Merged
Conversation
Basically #3246 (comment) Looking at https://github.com/docker-mailserver/docker-mailserver/actions/runs/4699505235/jobs/8333061595?pr=3261, we can see that `postconf` is complaining: ```txt postconf: warning: /etc/postfix/main.cf: unused parameter: policyd-spf_time_limit=3600 ``` This PR resolves the matter and puts all the code that integrates policyd-spf in one place.
georglauterbach
added
area/scripts
kind/improvement
9 tasks
polarathene
previously approved these changes
Apr 14, 2023
Co-authored-by: Brennan Kinney <[email protected]>
polarathene
reviewed
Apr 14, 2023
| /etc/postfix/main.cf | ||
| # SPF policy settings | ||
| postconf 'policyd-spf_time_limit = 3600' | ||
| EOF |
Member
There was a problem hiding this comment.
EOF was advised to be dropped for this suggestion.
Member
Author
georglauterbach
added a commit
that referenced
this pull request
Apr 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Basically #3246 (comment).
Looking at https://github.com/docker-mailserver/docker-mailserver/actions/runs/4699505235/jobs/8333061595?pr=3261, we can see that
postconfis complaining:This PR resolves the matter and puts all the code that integrates policyd-spf in one place.
The log says
'Disabling policyd-spf', when actually doing nothing, but this is okay, since1Type of change
Checklist:
docs/)