Skip to content

config-examples: update fail2ban config examples with current DMS default values#3258

Merged
casperklein merged 2 commits intodocker-mailserver:masterfrom
ap-wtioit:master-update_fail2ban_config_example
Apr 16, 2023
Merged

config-examples: update fail2ban config examples with current DMS default values#3258
casperklein merged 2 commits intodocker-mailserver:masterfrom
ap-wtioit:master-update_fail2ban_config_example

Conversation

@ap-wtioit
Copy link
Copy Markdown
Contributor

@ap-wtioit ap-wtioit commented Apr 14, 2023 •
edited
Loading

Description

Update the fail2ban config examples with the values from mailserver/docker-mailserver:edge.

Discussed in #3256
Values effective in docker-mailserver updated in 12.0.0 (new fail2ban version -> /etc/fail2ban/fail2ban.conf) and #3243 (target/fail2ban/jail.local -> /etc/fail2ban/jail.local)

Type of change

  • Improvement (non-breaking change that does improve existing functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Info @wt-io-it

@georglauterbach georglauterbach added service/security/fail2ban kind/improvement Improve an existing feature, configuration file or the documentation area/documentation labels Apr 14, 2023
@georglauterbach georglauterbach added this to the v12.1.0 milestone Apr 14, 2023
georglauterbach
georglauterbach approved these changes Apr 14, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@casperklein if you approve, you can go ahead and merge this PR.

We should further discuss (with @polarathene) if increasing maxretries again is a good idea - which it probably is after thinking about it for a while. We can use #3256 as the discussion already has some related content there.

@casperklein
Copy link
Copy Markdown
Member

casperklein commented Apr 16, 2023

Good cleanup 👍 Regarding the adjusted values (retries, bantime etc), we should wait until it's decided which road we take (keeping it strict or revert the changes).

@georglauterbach
Copy link
Copy Markdown
Member

georglauterbach commented Apr 16, 2023

Good cleanup 👍 Regarding the adjusted values (retries, bantime etc), we should wait until it's decided which road we take (keeping it strict or revert the changes).

IMO we should merge this and the PR that adjusts the config must take care of adjusting this file again. But I won't insist on this being merged, just my opinion.

@casperklein casperklein enabled auto-merge (squash) April 16, 2023 20:17
@casperklein casperklein merged commit 95c8123 into docker-mailserver:master Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casperklein casperklein casperklein approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

@ap-wtioit ap-wtioit

Labels

area/documentation kind/improvement Improve an existing feature, configuration file or the documentation service/security/fail2ban

Projects

None yet

Milestone

v12.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ap-wtioit @casperklein @georglauterbach