Skip to content

Rspamd: replace reject_unknown_client_hostname with Rspamd HFILTER_HOSTNAME_UNKNOWN and make it configurable#3248

Merged
georglauterbach merged 6 commits intomasterfrom
rspamd/reverse-hostnames
Apr 11, 2023
Merged

Rspamd: replace reject_unknown_client_hostname with Rspamd HFILTER_HOSTNAME_UNKNOWN and make it configurable#3248
georglauterbach merged 6 commits intomasterfrom
rspamd/reverse-hostnames

Conversation

@georglauterbach
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach commented Apr 11, 2023 •
edited
Loading

Description

Please quickly read over #3228 :) Removes reject_unknown_client_hostname and (re-)add the test to Rspamd (via HFILTER_HOSTNAME_UNKNOWN).

Fixes #3228
Fixes #2970

Type of change

  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@georglauterbach georglauterbach added kind/new feature A new feature is requested in this issue or implemeted with this PR area/features service/security/rspamd labels Apr 11, 2023
@georglauterbach georglauterbach added this to the v12.1.0 milestone Apr 11, 2023
@georglauterbach georglauterbach self-assigned this Apr 11, 2023
@georglauterbach
add option to adjust the score
a1c2b25 
add check on RSPAMD_HFILTER_UNKNOWN_SCORE & check if the var actually is a number and show an error if not
@georglauterbach georglauterbach force-pushed the rspamd/reverse-hostnames branch 2 times, most recently from 5824010 to c6335db Compare April 11, 2023 08:16
@georglauterbach georglauterbach force-pushed the rspamd/reverse-hostnames branch from c6335db to 87ccf1d Compare April 11, 2023 08:17
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 11, 2023

Documentation preview for this PR is ready! 🎉

Built with commit: 87ccf1d

@polarathene
Copy link
Copy Markdown
Member

polarathene commented Apr 11, 2023

@GoliathLabs how do you feel about this replacing your Postfix usage from: #2691 ?

Are you using the rspamd feature, if not do you plan to adopt it at some point? Or do you need the feature to remain in Postfix? (@georglauterbach may still drop it by the end of the year once he switches rspamd on as a default enabled feature)

@GoliathLabs
Copy link
Copy Markdown
Contributor

GoliathLabs commented Apr 11, 2023

@GoliathLabs how do you feel about this replacing your Postfix usage from: #2691 ?

Are you using the rspamd feature, if not do you plan to adopt it at some point? Or do you need the feature to remain in Postfix? (@georglauterbach may still drop it by the end of the year once he switches rspamd on as a default enabled feature)

I have already used rspamd on one of my older mailserver instances, so I plan to use rspamd with docker-mailserver as well. I wouldn't mind replacing my reject_unknown_client_hostname configuration with the configurable one of rspamd.

@georglauterbach georglauterbach merged commit 9a28415 into master Apr 11, 2023
@georglauterbach georglauterbach deleted the rspamd/reverse-hostnames branch April 11, 2023 16:51
@casperklein
Copy link
Copy Markdown
Member

casperklein commented Apr 11, 2023 •
edited
Loading

Correct me if I am wrong. This PR removed the feature reject_unknown_client_hostname. So when not using rspamd, you'll lose that functionality? If so, why?

@georglauterbach
Copy link
Copy Markdown
Member Author

georglauterbach commented Apr 11, 2023

Correct me if I am wrong. This PR removed the feature reject_unknown_client_hostname. So when not using rspamd, you'll lose that functionality? If so, why?

We had requests and complaints that this might be too restrictive. If you want me to, I can make this configurable for Postfix again - via an ENV like POSTFIX_REJECT_UNKNOWN_CLIENT_HOSTNAME=1. Just let me know :)

Another rationale is that with Rspamd, this will all be a factor for the spam score metric, which is IMO desirable.

@casperklein
Copy link
Copy Markdown
Member

casperklein commented Apr 11, 2023

We had requests and complaints that this might be too restrictive

Not sure, if that represents the majority and justify removal. For me this works perfectly and avoids a lot of SPAM.

I can make this configurable for Postfix again

Yes, please 👍

@georglauterbach georglauterbach mentioned this pull request Apr 12, 2023
Merged
8 tasks
georglauterbach added a commit that referenced this pull request Apr 16, 2023
@georglauterbach
Posfix: add option to re-enable reject_unknown_client_hostname after …
c8dfb9a 
…#3248 (#3255)
@polarathene polarathene mentioned this pull request Mar 22, 2024
Merged
7 tasks
@polarathene polarathene mentioned this pull request May 9, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polarathene polarathene polarathene approved these changes

@casperklein casperklein Awaiting requested review from casperklein

+1 more reviewer

@GoliathLabs GoliathLabs GoliathLabs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@georglauterbach georglauterbach

Labels

area/features kind/new feature A new feature is requested in this issue or implemeted with this PR service/security/rspamd

Projects

Rspamd Integration
Archived in project

Milestone

v12.1.0

4 participants

@georglauterbach @polarathene @GoliathLabs @casperklein