fix: GH docs update workflow#3241
Merged
georglauterbach merged 3 commits intomasterfrom Apr 10, 2023
Merged
Conversation
This resolves the bug seen in https://github.com/docker-mailserver/docker-mailserver/actions/runs/4655940825/jobs/8239089021 where we execute `ln -sf v12.0 latest`, which will not replace the latest symlink, but create a new one: `v11.3/v12.0`, i.e. create a symlink inside what `latest` pointed to earlier, in this case `v11.3`. This can easily be resolved by deleting `latest` first and not using `-f` gflags that hide errors and such.
This is not necessary and not desirable as it hides the error seen in https://github.com/docker-mailserver/docker-mailserver/actions/runs/4655940825/jobs/8239089021 . We do **not** need it because the whole job is already guarded by `if: startsWith(github.ref, 'refs/tags/')`, hence there will not be an update unless a new tag is published.
georglauterbach
added
area/ci
priority/high
area/documentation
kind/bug/fix
georglauterbach
changed the title
polarathene
approved these changes
Apr 10, 2023
Member
|
Thanks for catching that and resolving it so quickly ❤️ |
Member
Author
I always monitor releases closely to catch issues like that :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We execute
ln -sf v12.0 latest, which will not replace thelatestsymlink, but create a new one:v11.3/v12.0, i.e. create a symlink inside whatlatestpointed to earlier, in this casev11.3.This can easily be resolved by deleting
latestfirst and not using-fflags that hide errors and such.Fixes error as seen in https://github.com/docker-mailserver/docker-mailserver/actions/runs/4655940825/jobs/8239089021.
Type of change
Checklist:
docs/)