I had really hoped not to see the return of wrappers 🤢 but it may currently be our only option..

Yes, unless someone comes up with a proper solution to run in foreground, this is the only way.

I will review in approx 12 hours.

I found out why I could not reproduce the problem on my system... My current install has a different docker.service config for LimitNOFILE=infinity, causing that ulimit problem with container having over a billion FDs to close.

It appeared like postsrsd was running to me, but it was stalling for 8 minutes to startup as it iterated through all those syscalls 😅 So now I can reproduce 👍

@polarathene I think this PR as absolutely fine to merge even without your review, so if you want to save some time, let us know :)

Sorry, went on a bit of a detour, I'll get back to this today 😅

Yes, unless someone comes up with a proper solution to run in foreground, this is the only way.

Tada 🎉 #3128 (comment)

There isn't any tests in place that actually verify postsrsd is working, only config matches expectations, but I'm pretty sure that's working properly now.

What would you like to use?

Yes, unless someone comes up with a proper solution to run in foreground, this is the only way.

Tada 🎉 #3128 (comment)

What would you like to use?

Definitely your solution 🎉🚀

I can confirm this works 🚀

I noticed this difference between the old wrapper and your new foreground solution:

Old:

/usr/sbin/postsrsd -f 10001 -r 10002 -d example.test -s /etc/postsrsd.secret -a = -n 4 -N 4 -u postsrsd -p /var/run/postsrsd.pid -c /var/lib/postsrsd -l 127.0.0.1 -D -X

New:

postsrsd -e -p /var/run/postsrsd.pid

Can you confirm, that this does not introduce any regressions due to missing parameters? Are these all either default values or defined in /etc/default/postsrsd?

Can you confirm, that this does not introduce any regressions due to missing parameters? Are these all either default values or defined in /etc/default/postsrsd?

You only need to provide the domain and secret I think to run the command, the defaults are shown with the -h command flag and can be compared to the init script and config file we ship (slightly out of date from upstream and init script IIRC).

I provided captured snippets and relevant details for reference a while ago.

There's possibly something missing, I need to sleep but can double check tomorrow to confirm if parity is kept 👍

That said we may want to opt-out of the chroot (along with Dovecot) for v12?

There's possibly something missing, I need to sleep but can double check tomorrow to confirm if parity is kept 👍

👍

That said we may want to opt-out of the chroot (along with Dovecot) for v12?

I see no problem with that. But let's do it separated from this PR.

Yep all looks good 👍 (except we would now run in foreground instead of -D daemon mode)

postsrsd 1.x series will take either args to config, or with -e match these ENV, otherwise use the defaults listed via -h (which is the case for anything we don't provide).

I referenced the init script + -h output I shared earlier , the PostSRSd ENV config file we provide and PostSRSd official config (ours is slightly different, but aligns with the modifications Debian package already applies, ours just is outdated missing some added settings, but the defaults are the same).

I see no problem with that. But let's do it separated from this PR.

💯