Skip to content

DRY: Replace path with variable in mail_state.sh#3153

Merged
casperklein merged 4 commits intodocker-mailserver:masterfrom
casperklein:mail-state
Mar 5, 2023
Merged

DRY: Replace path with variable in mail_state.sh#3153
casperklein merged 4 commits intodocker-mailserver:masterfrom
casperklein:mail-state

Conversation

@casperklein
Copy link
Copy Markdown
Member

@casperklein casperklein commented Mar 5, 2023 •
edited
Loading

Description

Small change: Replace hard-coded path with variable.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein added this to the v12.0.0 milestone Mar 5, 2023
@casperklein casperklein self-assigned this Mar 5, 2023
@casperklein casperklein enabled auto-merge (squash) March 5, 2023 12:15
@casperklein casperklein added area/scripts kind/improvement Improve an existing feature, configuration file or the documentation labels Mar 5, 2023
@georglauterbach
Copy link
Copy Markdown
Member

georglauterbach commented Mar 5, 2023

I would have adjusted it quickly, but since this branch does not belong to DMS and you disabled maintainer edits, you'll need to surround the vars with "" yourself.

Otherwise, nice change! LGTM 👍🏼

georglauterbach
georglauterbach reviewed Mar 5, 2023
View reviewed changes
Comment thread target/scripts/startup/setup.d/mail_state.sh Outdated
@casperklein casperklein merged commit a8f6fa6 into docker-mailserver:master Mar 5, 2023
georglauterbach added a commit that referenced this pull request Mar 5, 2023
@georglauterbach
fix regression introduced in #3153
178ab7d
@georglauterbach georglauterbach mentioned this pull request Mar 5, 2023
Merged
7 tasks
georglauterbach added a commit that referenced this pull request Mar 5, 2023
@georglauterbach
fix regression introduced in #3153 (#3157)
b5fc40e
@casperklein casperklein deleted the mail-state branch March 13, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@georglauterbach georglauterbach georglauterbach approved these changes

@polarathene polarathene Awaiting requested review from polarathene

Assignees

@casperklein casperklein

Labels

area/scripts kind/improvement Improve an existing feature, configuration file or the documentation

Projects

None yet

Milestone

v12.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@casperklein @georglauterbach