Skip to content

release: v12.0.0#3146

Merged
georglauterbach merged 11 commits intomasterfrom
release/v12.0.0
Apr 10, 2023
Merged

release: v12.0.0#3146
georglauterbach merged 11 commits intomasterfrom
release/v12.0.0

Conversation

@georglauterbach
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach commented Mar 3, 2023 •
edited
Loading

Description

This PR marks the feature freeze phase for the v12.0.0 release.

The current :edge image will be tested for roughly 10 days and if no bugs get reported, v12.0.0 will be released. During this testing period, only PRs that do not change functionality will be merged.

If you want to support us, give the latest :edge image a try and report any issues you encounter back to this PR.

Documentation updates may be merged. Feature freeze is in place until 9 April 2023.

Closes #2952
Closes #3098
Closes #3202

Type of change

  • Release

Release-Checklist:

  • Update CHANGELOG.md
  • Update version in VERSION
  • Draft release

@georglauterbach georglauterbach added priority/high kind/release This PR marks a release pr/waiting for other PR to get merged This PR is waiting for another / other PR(s) to get merged labels Mar 3, 2023
@georglauterbach georglauterbach added this to the v12.0.0 milestone Mar 3, 2023
@georglauterbach georglauterbach self-assigned this Mar 3, 2023
@georglauterbach georglauterbach changed the title bump version in VERSION release: v12.0.0 Mar 3, 2023
@georglauterbach georglauterbach marked this pull request as draft March 3, 2023 16:21
@georglauterbach
Copy link
Copy Markdown
Member Author

georglauterbach commented Mar 3, 2023

Please add your contributions to CHANGELOG.md as well :)

@georglauterbach georglauterbach mentioned this pull request Mar 4, 2023
Merged
5 tasks
@polarathene

This comment was marked as resolved.

Sign in to view
@georglauterbach

This comment was marked as outdated.

Sign in to view
georglauterbach and others added 4 commits March 7, 2023 14:57
@georglauterbach
update CHANGELOG
545db33 
This is for an upcoming PR, but I may not have time or I may forget
updating the changelog after merging #3159. Hence, I'll do it now.
@polarathene
chore: Add contributions from polarathene
eaf55c2 
I've ignored some of my PRs, notably PRs only related to test suite. They did not seem that relevant to the release.
@polarathene
chore: Clearly make users aware of big changes
ec4d310
@polarathene
chore: Add misc contributions
d971a6b
@polarathene

This comment was marked as resolved.

Sign in to view
@georglauterbach

This comment was marked as outdated.

Sign in to view
@polarathene

This comment was marked as outdated.

Sign in to view
@georglauterbach

This comment was marked as resolved.

Sign in to view
@polarathene
Copy link
Copy Markdown
Member

polarathene commented Mar 30, 2023 •
edited
Loading

Just tell me, I can try to tackle this as well and relieve you from some of the weight

Much appreciated! ❤️ 🙏

@georglauterbach georglauterbach mentioned this pull request Mar 30, 2023
Merged
7 tasks
@georglauterbach georglauterbach removed the pr/waiting for other PR to get merged This PR is waiting for another / other PR(s) to get merged label Mar 31, 2023
@georglauterbach georglauterbach marked this pull request as ready for review March 31, 2023 10:19
@georglauterbach
Copy link
Copy Markdown
Member Author

georglauterbach commented Mar 31, 2023 •
edited
Loading

Feature freeze is now in place! It lasts 10 days (because v12.0.0 is really big).

I will draft a release on GitHub later.

EDIT: Done.

casperklein and others added 2 commits April 6, 2023 00:47
@casperklein
Merge branch 'master' into release/v12.0.0
2d49735
@polarathene
chore: Raise awareness of breaking change
afa4490 
This would be breaking if any scripts (eg: `user-patches.sh`) attempt to modify `smtpd_sender_restrictions` via an operation like `sed`.
@georglauterbach georglauterbach mentioned this pull request Apr 8, 2023
Closed
@casperklein
Copy link
Copy Markdown
Member

casperklein commented Apr 9, 2023

I think it's fine to deprecate the ONE_DIR ENV with this release?

@polarathene
Copy link
Copy Markdown
Member

polarathene commented Apr 9, 2023

I think it's fine to deprecate the ONE_DIR ENV with this release?

Yeah, sounds good. It's effectively only relevant to mail_state.sh now and from v12 only really cares about /var/mail-state being present to toggle the behaviour.

@georglauterbach
Copy link
Copy Markdown
Member Author

georglauterbach commented Apr 9, 2023 •
edited
Loading

Let's please do this with v13.0.0; which should not take too long actually.

Today is the end of the freeze. I don't know what your deprecation would look like, but for ONE_DIR=0, an addition to _environment_variables_backwards_compatibility is required - which would make the freeze useless.

I don't mind skipping v12.1.0 and going to v13.0.0 immediately, but please let's not push this in here as well.

v13.0.0 will focus on some ENV changes already, it's more fitting therefore to go into v13.0.0.

I propose to have a "fast" v12.1.0 release to stabilise Rspamd, and then introduce these breaking changes.

@georglauterbach
Copy link
Copy Markdown
Member Author

georglauterbach commented Apr 9, 2023

Please provide your approval if you think this is fine :) Happy Easter!

@casperklein
Copy link
Copy Markdown
Member

casperklein commented Apr 9, 2023

Just to be clear, I didn't plan to do any code changes or something. Just mention it in the changelog, that ONE_DIR=0 is marked deprecated and will be removed in the future (v14 or later). Just to inform people early.
I am fine with handling this later.

@georglauterbach
Copy link
Copy Markdown
Member Author

georglauterbach commented Apr 10, 2023

Just to be clear, I didn't plan to do any code changes or something. Just mention it in the changelog, that ONE_DIR=0 is marked deprecated and will be removed in the future (v14 or later). Just to inform people early.

I am fine with handling this later.

👍🏼 I think we should be as thorough as possible and add a bit of code for the =0 case, hence my proposal.

I will make sure to include this in v13.0.0.

This PR is ready to be merged now. I will take care of the release :)

@georglauterbach georglauterbach merged commit dc8a080 into master Apr 10, 2023
@georglauterbach georglauterbach deleted the release/v12.0.0 branch April 10, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casperklein casperklein casperklein approved these changes

@polarathene polarathene polarathene approved these changes

Assignees

@georglauterbach georglauterbach

Labels

kind/release This PR marks a release priority/high

Projects

None yet

Milestone

v12.0.0

3 participants

@georglauterbach @polarathene @casperklein