ci(fix): Only apply permissions at the job level#3142
Merged
georglauterbach merged 1 commit intomasterfrom Mar 3, 2023
Merged
Conversation
If permissions are specified at the workflow level, any that are not explicitly set became `none` and jobs cannot request that to change. Permissions are therefore scoped to the job itself.
georglauterbach
approved these changes
Mar 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix for #3106 as a recent run of the Action failed.
If permissions are specified at the workflow level, any that are not explicitly set become
noneand jobs cannot request that to change.Permissions are therefore scoped to the job itself (Github Actions docs for the step requiring the permission).
Type of change