not sure hot to test this locally

We have a rather good documentation on how we run tests if that is something you are wondering about. If it is about the change itself, I'm not 100% certain either. I guess running it and seeing whether it produces errors is a good way to start :)

I will add some comments, but the changes as-is look quite good.

We have a rather good documentation on how we run tests if that is something you are wondering about.

FYI: running the test fails with:

   status : 1
   output (2 lines):
     Unable to find image 'mailserver-testing:ci' locally

so I ran make build (which is not in a that page). but that also fails:

❯ make build
[+] Building 0.3s (3/3) FINISHED
 => [internal] load build definition from Dockerfile                                                                                                                                                              0.0s
 => => transferring dockerfile: 12.40kB                                                                                                                                                                           0.0s
 => [internal] load .dockerignore                                                                                                                                                                                 0.0s
 => => transferring context: 59B                                                                                                                                                                                  0.0s
 => ERROR resolve image config for docker.io/docker/dockerfile:1                                                                                                                                                  0.3s
------
 > resolve image config for docker.io/docker/dockerfile:1:
------
failed to solve with frontend dockerfile.v0: failed to solve with frontend gateway.v0: rpc error: code = Unknown desc = error getting credentials - err: exit status 1, out: `Cannot autolaunch D-Bus without X11 $DISPLAY`
make: *** [Makefile:21: build] Error 1

If it is about the change itself, I'm not 100% certain either. I guess running it and seeing whether it produces errors is a good way to start :)

yeah, I was thinking, how to test in a single test. (without having setup lots of temp records)

If it is about the change itself, I'm not 100% certain either.

We don't have any known way to reproduce it. Best we can do is check logs for the same permission failures, but if we can't reproduce the conditions to fail reliably, I'd rather not.

There's this PR and the linked issue which has plenty of details behind the change / issue, if we need to revisit this after release.

so I ran make build (which is not in a that page). but that also fails:

Are you on a Linux host? What version is your Docker Engine?

Are you on a Linux host? What version is your Docker Engine?

U was running it on an unused vps somewhere:

davy@vps1 /tmp/docker-mailserver sasl-socket-move
❯ docker --version
Docker version 20.10.21, build baeda1f

davy@vps1 /tmp/docker-mailserver sasl-socket-move
❯ cat /etc/issue
Debian GNU/Linux 10 \n \l

so I ran make build (which is not in a that page)

Excuse me, but it is explicitly written in the docs: "You will first need to build the container image via make build".

so I ran make build (which is not in a that page)

Excuse me, but it is explicitly written in the docs: "You will first need to build the container image via make build".

🤦🏼 my bad

Could you try logging in via SSH with X-Forwarding? The errror "Cannot autolaunch D-Bus without X11 $DISPLAY" suggests DISPLAY is not set; I have no idea why this would be required though 🤣

Ahh, there we go: https://anto.online/guides/cannot-autolaunch-d-bus-without-x11-display/. Maybe docker logout can help?

After updating docker the error persists. No idea why I need credentials to pull stuff (as in, not that chatty from this vps).

davy@vps1 /tmp/docker-mailserver sasl-socket-move
❯ make build
[+] Building 0.3s (3/3) FINISHED
 => [internal] load .dockerignore                                                                                                                                                                                 0.0s
 => => transferring context: 59B                                                                                                                                                                                  0.0s
 => [internal] load build definition from Dockerfile                                                                                                                                                              0.0s
 => => transferring dockerfile: 12.39kB                                                                                                                                                                           0.0s
 => ERROR resolve image config for docker.io/docker/dockerfile:1                                                                                                                                                  0.3s
------
 > resolve image config for docker.io/docker/dockerfile:1:
------
Dockerfile:1
--------------------
   1 | >>> # syntax=docker.io/docker/dockerfile:1
   2 |
   3 |     # This Dockerfile provides two stages: stage-base and stage-final
--------------------
ERROR: failed to solve: error getting credentials - err: exit status 1, out: `Cannot autolaunch D-Bus without X11 $DISPLAY`
make: *** [Makefile:21: build] Error 1

davy@vps1 /tmp/docker-mailserver sasl-socket-move
❯ docker --version
Docker version 23.0.1, build a5ee5b1

Docker seems to be trying to invoke a credentials helper which requires a graphical frontent, which of course is not enabled. Can you try logging out of all registries with Docker? AFAIK you do not need any credentials for building DMS.

in the end, some googling pointed out outdated credential helpers.

sudo apt remove golang-docker-credential-helpers

did the trick. such fun. it's now building. curious if I can also get this set3 suite to fail.

I actuall think this is a sporadic failure.. seems unrelated to me. Tests have been restarted.

UPDATE: Seems not to be sporadic.. weird. I am currently unable to investigate too, but maybe I can find some time today or tomorrow. Nevermind, found the issue: https://github.com/docker-mailserver/docker-mailserver/blob/master/test/config/dovecot-lmtp/user-patches.sh. The sed will now touch 0660 as well and replace it, which does not make sense. We need to adjust this file.

EDIT2: I am not yet sure how to go about this. @polarathene any idea?

EDIT3: Something like sed -i '/unix_listener lmtp {/,+4d' /etc/dovecot/conf.d/10-master.conf to delete the UNIX socket listener; uncommenting the TCP listener is another task though.

EDIT4: We could delete the whole service lmtp { section and just append to the file; that should work:

sed -i '/service lmtp {/,+13d' /etc/dovecot/conf.d/10-master.conf
cat >>/etc/dovecot/conf.d/10-master.conf << EOF

service lmtp {
  inet_listener lmtp {
    address = 0.0.0.0
    port = 24
  }
}
EOF

The failure happening in this PR is because of mode = 0660 now having another match for sed?

EDIT4: We could delete the whole service lmtp { section and just append to the file; that should work:

Yeah I guess that works. I think that section could be moved to a separate file and use the include syntax to have Dovecot handle it.

Then the test would just replace that include line or config file.

Yeah; using an include and changing the path if required is probably the best idea!

hey @georglauterbach it seems you have a better idea of what to change, so will you propose a patch?

hey @georglauterbach it seems you have a better idea of what to change, so will you propose a patch?

I can provide a patch and we can then rebase this PR.

EDIT: I have two pending PRs in the pipeline that I am currently waiting for to be merged; I will apply the patch afterwards:

• scripts: housekeeping & cleanup setup (1/2) #3121
• scripts: housekeeping & cleanup setup (2/2) #3123

I'm also fine with closing this PR in favor of a new PR that you make that merges these changes? I mean, I'm happy I could help diagnose this issue a bit, I don't need to have my name on the commits ;)

No worries, we'll take care of it if you like 👍

Alright; let's leave this open for now, I will close it when merging the PR that supersedes this PR.

Superseeded by #3131