scripts: housekeeping & cleanup setup (2/2)#3123
Merged
georglauterbach merged 8 commits intomasterfrom Feb 28, 2023
Merged
Conversation
See commit comment for f30f5c2
See commit comment for f30f5c2
See commit comment for f30f5c2 Additionally added `POSTFIX_DAGENT` to variables so it is properly set!
1. The Supervisor setup function name is now uniform with the early ENV var setup function 2. The functions needed for early ENV var setup were made private (by naming convention.. oh my)
This way, all the private functions in this stack come first.
georglauterbach
added
area/scripts
kind/improvement
This was referenced Feb 26, 2023
polarathene
previously approved these changes
Feb 27, 2023
Member
polarathene
left a comment
polarathene
left a comment
There was a problem hiding this comment.
Commits are cleanly separated; reviewing commit-by-commit is advised.
Really nice review diffs this time, quick and easy 😁 🎉
9 tasks
casperklein
previously approved these changes
Feb 27, 2023
Member
|
BTW: do we really need a separate fix stack? We could move those fixes into the corresponding setup functions. |
Member
Author
#3121 removed the stack entirely and did exactly what you proposed 😉 |
Member
Author
|
I will resolve conflicts tomorrow :) |
georglauterbach
dismissed stale reviews from casperklein and polarathene
via
41d08e4
The `start-daemons.sh` stack contained setup functionality, which I moved into the setup stack (for Postgrey, whose removal of PID files was not necessary because we already do that in `_setup_apply_fixes_after_configuration`) & Dovevot, for which the code for starting the daemon contained plain setup functionality entirely unrelated to the actual start). Sorry for requiring a review for this again, but I did not want to open yet another PR for this (since I'm currently swamping the project with PRs). Should be fearly easy to review this commit though, so all is well :)
polarathene
approved these changes
Feb 28, 2023
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
(First) Follow up of #3115. Sibling of #3121. This is mostly a cleanup & housekeeping PR; changes are partially split from #3112 to make reviewing easier.
Commits are cleanly separated; reviewing commit-by-commit is advised.
Type of change
Checklist:
docs/)