scripts: housekeeping & cleanup setup (1/2)#3121
Merged
georglauterbach merged 6 commits intomasterfrom Feb 27, 2023
Merged
Conversation
Not all functionality was migrated with this commit; the next commit will enhance the security setup, and in the next commit, the fixes are included.
This greatly improves readability and consistency in our security setup procedure. I am trying to start a new "calling convention" here, whereby the callee (the function called) will perform checks on what it actually needs to do. This way, we relief the caller from this burder, which in turn simplifies `_register_functions`. Moreover, the functions become uniform, because we can log appropriate messages for all cases! Follow-up PR will adopt this new convention step-by-step.
Remove functionality from `start-mailserver.sh` to put it into the appropriate stacks; this way, `start-mailserver.sh` does not need to know about any arrays at all and the arrays specific for each stack are in each stack. The functions for registering were moved as well, since this nicely encapsulates all state for a stack now in the stack file.
georglauterbach
added
area/scripts
kind/improvement
georglauterbach
changed the title
1. Split OpenDKIM & OpenDMARC functions and added proper comments 2. Made log messages uniform and added comment on why the log messages are as they are 3. Moved registering of functions (this is done in an effort to simplify the many small functions for Postfix into bigger ones in the future; moreover, the Postfix setup is now closer together)
This was referenced Feb 26, 2023
Member
Author
|
@casperklein do you want to review this PR too? Currently, auto-merge is enabled, which would cause this PR to be merged with one approval. If you want to review this PR, just disable auto-merge :) |
Closed
10 tasks
polarathene
approved these changes
Feb 27, 2023
Member
polarathene
left a comment
polarathene
left a comment
There was a problem hiding this comment.
The refactor commit had a few things going on that could have been better diffed as multiple commits, but other than that was easy enough to review through commits 👍
Good work 😀
9 tasks
casperklein
approved these changes
Feb 27, 2023
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
(First) Follow up of #3115. This is mostly a cleanup & housekeeping PR; changes are partially split from #3112 to make reviewing easier.
Commits are cleanly separated; reviewing commit-by-commit is advised.
In f30f5c2, I recommend looking at
setup.d/security/misc.shnot only via the diff view, but also directly at the file on the branch, because the diff is a bit fuzzy.Type of change
Checklist:
docs/)