Skip to content

docs: add docs about Abusix integration into Rspamd#3104

Merged
georglauterbach merged 3 commits intomasterfrom
docs/abusix
Feb 22, 2023
Merged

docs: add docs about Abusix integration into Rspamd#3104
georglauterbach merged 3 commits intomasterfrom
docs/abusix

Conversation

@georglauterbach
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach commented Feb 21, 2023

Description

Title says it all. See #3003 for (initial) reference. When adjusting this PR, commit immediately :D

Type of change

  • Improvement (non-breaking change that does improve existing functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@georglauterbach georglauterbach added kind/improvement Improve an existing feature, configuration file or the documentation area/documentation labels Feb 21, 2023
@georglauterbach georglauterbach added this to the v12.0.0 milestone Feb 21, 2023
@georglauterbach georglauterbach self-assigned this Feb 21, 2023
@georglauterbach georglauterbach changed the title docs: dd docs about Abusix integration into Rspamd docs: add docs about Abusix integration into Rspamd Feb 21, 2023
[Abusix]: https://abusix.com/
[abusix-rspamd-integration]: https://docs.abusix.com/abusix-mail-intelligence/gbG8EcJ3x3fSUv8cMZLiwA/getting-started/dmw9dcwSGSNQiLTssFAnBW#rspamd

[//]: # (General Links)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't want to mess up the general Rspamd links with links coming from examples, hence the example links for Abusix, and then a comment that shows that the general links are following.

Copy link
Copy Markdown
Member

@polarathene polarathene Feb 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[//]: # (General Links)

This is meant to be a markdown comment? I am not familiar with that, is it documented somewhere? I know of this kind:

Suggested change
[//]: # (General Links)
<!-- General Links -->

Copy link
Copy Markdown
Member Author

@georglauterbach georglauterbach Feb 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one you proposed works for GitHub (when rendering it to HTML), mine should be the most compatible for other platforms though [source]. I don't mind really, but I'm used to [//]: # () and it always worked for me in the past. We could change it though..

UPDATE: If you want to, just go ahead :)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some extensions that we could use with mkdocs to strip out comments. Or better having html processed instead to strip them probably 🤷‍♂️

Personally, I don't have an issue with them being present in the HTML markup, they're not rendered.


I appreciate the source link, thanks for that 👍

It still seems like a hacky workaround though. I'd like the CI to run something like lychee for docs PRs (I had some WIP work a while back, but didn't get around to finishing it) so that links are checked. Perhaps it won't get confused by that syntax 🤷‍♂️

I'll approve as it's not causing any problems atm, my preference for the HTML comment syntax is it'd likely be more familiar to anyone that comes across the line, less confusion is good but I'm not going to be fussy here until someone else expresses the same confusion 😅

Copy link
Copy Markdown
Member Author

@georglauterbach georglauterbach Feb 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright 👍🏼 I'll leave this open in case of future discussions.

@github-actions
Copy link
Copy Markdown
Contributor

Documentation preview for this PR is ready! 🎉

Built with commit: 432cbe1

@georglauterbach georglauterbach merged commit 9724060 into master Feb 22, 2023
@georglauterbach georglauterbach deleted the docs/abusix branch February 22, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/documentation kind/improvement Improve an existing feature, configuration file or the documentation

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants