Skip to content

ci: refactored sedfile & used _send_mail where possible#3103

Merged
georglauterbach merged 4 commits intomasterfrom
test/sedfile-refactoring
Feb 22, 2023
Merged

ci: refactored sedfile & used _send_mail where possible#3103
georglauterbach merged 4 commits intomasterfrom
test/sedfile-refactoring

Conversation

@georglauterbach
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach commented Feb 21, 2023

Description

Obvious. Review commit by commit should be easy.

Type of change

  • Improvement (non-breaking change that does improve existing functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@georglauterbach georglauterbach added area/tests kind/improvement Improve an existing feature, configuration file or the documentation labels Feb 21, 2023
@georglauterbach georglauterbach added this to the v12.0.0 milestone Feb 21, 2023
@georglauterbach georglauterbach self-assigned this Feb 21, 2023
@georglauterbach
Copy link
Copy Markdown
Member Author

georglauterbach commented Feb 21, 2023 •
edited
Loading

Left for refactoring now:

  • serial/mail_with_ldap.bats
  • serial/permit_docker.bats
  • serial/test_helper.bats
  • serial/tests.bats

I'd also love to see the ARM64 build being cached :D

polarathene
polarathene requested changes Feb 22, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this ❤️

I'd also love to see the ARM64 build being cached :D

If I can find the time to, I'll look into updating the CI to handle that. Presently juggling a few different workloads 😅

Comment thread test/tests/parallel/set3/mta/smtp_delivery.bats Outdated
@georglauterbach georglauterbach merged commit 35692a9 into master Feb 22, 2023
@georglauterbach georglauterbach deleted the test/sedfile-refactoring branch February 22, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polarathene polarathene polarathene approved these changes

Assignees

@georglauterbach georglauterbach

Labels

area/tests kind/improvement Improve an existing feature, configuration file or the documentation

Projects

None yet

Milestone

v12.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@georglauterbach @polarathene