Skip to content

tests: Migrate and combine ENV tests for *_INET_PROTOCOLS#3052

Merged
polarathene merged 3 commits intodocker-mailserver:masterfrom
polarathene:tests/migrate-inet-protocols
Feb 2, 2023
Merged

tests: Migrate and combine ENV tests for *_INET_PROTOCOLS#3052
polarathene merged 3 commits intodocker-mailserver:masterfrom
polarathene:tests/migrate-inet-protocols

Conversation

@polarathene
Copy link
Copy Markdown
Member

Description

These two features + tests were introduced years apart but serve the same functionality, just for either Postfix or Dovecot. Merged into single test.

Original PRs:

Type of change

  • Improvement (non-breaking change that does improve existing functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

These two features + tests were introduced years apart but serve the same purpose for both Postfix and Dovecot.
@polarathene polarathene added service/dovecot service/postfix area/tests kind/improvement Improve an existing feature, configuration file or the documentation labels Feb 1, 2023
@polarathene polarathene added this to the v12.0.0 milestone Feb 1, 2023
@polarathene polarathene self-assigned this Feb 1, 2023
georglauterbach
georglauterbach previously approved these changes Feb 1, 2023
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two suggestions notes, LGTM 👍🏼

Comment thread test/tests/parallel/set1/network_inet_protocols.bats Outdated
Comment thread test/tests/parallel/set1/network_inet_protocols.bats Outdated
Comment thread test/tests/parallel/set1/network_inet_protocols.bats Outdated
Comment thread test/tests/parallel/set1/network_inet_protocols.bats Outdated
Comment thread test/tests/parallel/set1/network_inet_protocols.bats Outdated
@polarathene polarathene merged commit 7a61214 into docker-mailserver:master Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/tests kind/improvement Improve an existing feature, configuration file or the documentation service/dovecot service/postfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants