tests: Reduce time taken by a third for testing cipher suites#3050
Merged
polarathene merged 2 commits intodocker-mailserver:masterfrom Feb 2, 2023
Merged
Conversation
Using `--openssl` uses the native `openssl` package within the image instead of the older `1.0.2` bundled from `testssl.sh`. The test is only testing cipher suite compatibility is what we expect it to be, thus we do not need to run `testssl.sh` with a broader range of ciphers.
polarathene
added
area/tests
kind/improvement
casperklein
approved these changes
Feb 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This improvement is from investigating the performance of
testssl.shcontainers. The test goes from ~300 sec locally to ~200 sec.Using
--openssluses the nativeopensslpackage within the image instead of the older1.0.2bundled fromtestssl.sh.The test is only testing cipher suite compatibility is what we expect it to be, thus we do not need to run
testssl.shwith a broader range of ciphers.Type of change
Checklist: