tests: tls_cipherlists should configure testssl.sh to use CA cert#3037
Merged
polarathene merged 2 commits intodocker-mailserver:masterfrom Jan 29, 2023
Merged
Conversation
This doesn't make any difference to the tests performed here (_partly due to `--preference`_). It would make a difference if performing a test for receiving a grade, which would otherwise fail due to chain of trust not being verifiable for a self-signed certificate (_or a signed certificate without a CA public key to verify against_)
polarathene
added
area/security
area/tests
kind/improvement
georglauterbach
approved these changes
Jan 28, 2023
casperklein
approved these changes
Jan 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Minor change that may be useful in future tests for TLS.
This doesn't make any difference to the tests performed here (partly due to
--preference).It would make a difference if performing a test for receiving a grade - which would otherwise fail due to chain of trust not being verifiable for a self-signed certificate (or a signed certificate without a CA public key to verify against).
NOTE: The ENV required
ADDTL_CA_FILESis specific to thetestssl.sh:3.1devrolling release. Earlier versions usedADDITIONAL_CA_FILES.Type of change
Checklist: