tests(refactor): Adjust mail_tls_dhparams.bats#2994
Merged
polarathene merged 4 commits intodocker-mailserver:masterfrom Jan 11, 2023
Merged
tests(refactor): Adjust mail_tls_dhparams.bats#2994polarathene merged 4 commits intodocker-mailserver:masterfrom
mail_tls_dhparams.bats#2994polarathene merged 4 commits intodocker-mailserver:masterfrom
Conversation
There is no longer special handling for this ENV with this feature, these variant test cases serve no value.
Converted to new common setup helper methods and testing structure. No `setup_file` needed. Only two test cases used now, the Mozilla check is bundled into the default params test case where it's relevant. Refactored some logic into common functions. Should be easier to grok intention.
polarathene
added
area/tests
kind/improvement
casperklein
reviewed
Jan 11, 2023
Co-authored-by: Casper <[email protected]>
georglauterbach
requested changes
Jan 11, 2023
Member
georglauterbach
left a comment
georglauterbach
left a comment
There was a problem hiding this comment.
Just the one comment; otherwise LGTM 👍🏼
As per review feedback
casperklein
approved these changes
Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ONE_DIRhandling was removed for this feature in Sep 2021, dropping those redundant test cases.Checklist: