Skip to content

Fix several typos#2990

Merged
casperklein merged 2 commits intodocker-mailserver:masterfrom
casperklein:typos
Jan 10, 2023
Merged

Fix several typos#2990
casperklein merged 2 commits intodocker-mailserver:masterfrom
casperklein:typos

Conversation

@casperklein
Copy link
Copy Markdown
Member

@casperklein casperklein commented Jan 9, 2023 •
edited
Loading

Description

Fix typos..

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein self-assigned this Jan 9, 2023
@casperklein casperklein requested a review from a team January 9, 2023 02:53
@casperklein casperklein added the kind/improvement Improve an existing feature, configuration file or the documentation label Jan 9, 2023
@casperklein casperklein added this to the v12.0.0 milestone Jan 9, 2023
georglauterbach
georglauterbach approved these changes Jan 9, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 9, 2023

Documentation preview for this PR is ready! 🎉

Built with commit: 96330a9

@casperklein
Copy link
Copy Markdown
Member Author

casperklein commented Jan 9, 2023 •
edited
Loading

Tests failing again sporadically 😠

@georglauterbach
Copy link
Copy Markdown
Member

georglauterbach commented Jan 9, 2023 •
edited
Loading

Tests failing again sporadically 😠

Was #2988 already in the first commit? I see, it's a different failure. But I haven't seen this one before; it's in the serial tests, so it wasn't actually touched. Weird..

polarathene
polarathene approved these changes Jan 10, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you use a tool to identify these, or you were actually scanning through these documents finding typos manually? (or some syntax highlight/lint feature in IDE?) 🤔

@casperklein casperklein merged commit 6ac59ef into docker-mailserver:master Jan 10, 2023
@casperklein casperklein deleted the typos branch January 10, 2023 13:13
@casperklein
Copy link
Copy Markdown
Member Author

casperklein commented Jan 10, 2023

I used good old grep together with a file that contains common typos:

grep -F -f common-typos.txt -R docker-mailserver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polarathene polarathene polarathene approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

@casperklein casperklein

Labels

kind/improvement Improve an existing feature, configuration file or the documentation

Projects

None yet

Milestone

v12.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@casperklein @georglauterbach @polarathene