Skip to content

Add tools (ping & dig) to the image#2989

Merged
casperklein merged 2 commits intomasterfrom
casperklein-patch-1
Jan 9, 2023
Merged

Add tools (ping & dig) to the image#2989
casperklein merged 2 commits intomasterfrom
casperklein-patch-1

Conversation

@casperklein
Copy link
Copy Markdown
Member

@casperklein casperklein commented Jan 8, 2023 •
edited
Loading

Description

This PR adds the ping and dig commands to the image, which are useful for debugging.

Fixes #2987

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein changed the title Add tools (ping & dig) Add tools (ping & dig) to the image Jan 8, 2023
@casperklein casperklein self-assigned this Jan 8, 2023
@casperklein casperklein added this to the v12.0.0 milestone Jan 8, 2023
@casperklein casperklein added area/ci kind/improvement Improve an existing feature, configuration file or the documentation labels Jan 8, 2023
@casperklein casperklein requested a review from a team January 8, 2023 17:34
@casperklein casperklein marked this pull request as ready for review January 8, 2023 17:34
@casperklein casperklein mentioned this pull request Jan 8, 2023
Closed
@georglauterbach
Copy link
Copy Markdown
Member

georglauterbach commented Jan 8, 2023

#2988 will fix the test failure seen here too.

polarathene
polarathene approved these changes Jan 8, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a feeling that bind9-dnsutils isn't going to be obvious that it's only added for providing dig if someone tries to review packages at some point in the future that isn't a currently active maintainer 😅

Personally doggo and q(feature comparison to dig and others) looks interesting? ...But understandably they're larger in size and users aren't likely to discover these in the image, but might attempt the common dig, so I nevermind (they can add those manually since they can just pull in the binaries from github releases)

@casperklein
Copy link
Copy Markdown
Member Author

casperklein commented Jan 9, 2023

BTW: If I am unsure what files/binarys a package provides, I use dpkg -L bind9-dnsutils for example.

Never heard of dog/doggo/q etc before, but they look promising. I'll take a closer look at them and may use them myself. However, compared with dig, they are pretty unknown, while dig is a well known standard tool.
The same goes for ping. As mentioned in the other issue, there are alternative ways like using curl. But that again, is not well known and I bet, most people will start trying to run "ping" at first 😆

@casperklein casperklein merged commit eeb6b72 into master Jan 9, 2023
@casperklein casperklein deleted the casperklein-patch-1 branch January 9, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polarathene polarathene polarathene approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

@casperklein casperklein

Labels

area/ci kind/improvement Improve an existing feature, configuration file or the documentation

Projects

None yet

Milestone

v12.0.0

Development

Successfully merging this pull request may close these issues.

What is the DNS Server used by DMS? dig/dog to the rescue?

3 participants

@casperklein @georglauterbach @polarathene