tests(fix): wait_until_change_detection_event_completes to count#2974
Merged
georglauterbach merged 1 commit intodocker-mailserver:masterfrom Jan 4, 2023
Merged
Conversation
Counting and comparing this observation instead is simpler, and more reliable at detecting change events that start and complete very quickly (_within the same second_)
georglauterbach
approved these changes
Jan 4, 2023
casperklein
approved these changes
Jan 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to a recent PR for improving processing time of a change event: #2947 (comment)
The CI was not as slow as expected, so here is the proper fix (at least I believe this should be reliable?):
Fixes #2966
Closes #2971
Type of change
Checklist: