Skip to content

docs: FAQ - Add note for devnull alias gotcha when using a catchall rule#2949

Merged
polarathene merged 2 commits intodocker-mailserver:masterfrom
worldworm:master
Jan 11, 2023
Merged

docs: FAQ - Add note for devnull alias gotcha when using a catchall rule#2949
polarathene merged 2 commits intodocker-mailserver:masterfrom
worldworm:master

Conversation

@worldworm
Copy link
Copy Markdown
Contributor

@worldworm worldworm commented Dec 22, 2022 •
edited
Loading

Description

Documents the findings from: #2948

https://pullrequest-2949--dms-doc-previews.netlify.app/faq/#how-can-i-delete-all-the-emails-for-a-specific-user
grafik

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation improvement only

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@polarathene polarathene changed the title updates docs faq devnull with sub-catch-all docs: FAQ - Add note for devnull alias gotcha when using a catchall rule Dec 23, 2022
@polarathene
Copy link
Copy Markdown
Member

polarathene commented Dec 23, 2022

Hey, just so you know I appreciate the time and initiative you've put in to open an issue and create this PR 👍

It's been a busy day, but I would like to try check something regarding your issue first before reviewing/approving this PR. I just wanted to provide you a heads-up regarding the delay in a response 😅

Regarding the preview, if your indentation for the code block beneath matches the admonition you added, it should then be rendered inside the admonition :)

@polarathene polarathene self-assigned this Dec 23, 2022
@polarathene polarathene added priority/low kind/improvement Improve an existing feature, configuration file or the documentation area/documentation labels Dec 23, 2022
@polarathene polarathene added this to the v12.0.0 milestone Dec 23, 2022
@worldworm
Copy link
Copy Markdown
Contributor Author

worldworm commented Dec 23, 2022

I have added the indentation 😄
image

polarathene
polarathene approved these changes Jan 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, this is fine to merge.

I haven't had time to do the investigation I wanted to yet, and not sure when I'll get around to that 😅

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 11, 2023

Documentation preview for this PR is ready! 🎉

Built with commit: 506bf92

@polarathene polarathene merged commit f5bcfa2 into docker-mailserver:master Jan 11, 2023
@polarathene polarathene mentioned this pull request Apr 23, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casperklein casperklein casperklein approved these changes

@polarathene polarathene polarathene approved these changes

Assignees

@polarathene polarathene

Labels

area/documentation kind/improvement Improve an existing feature, configuration file or the documentation priority/low

Projects

None yet

Milestone

v12.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@worldworm @polarathene @casperklein