Skip to content

Fix dovecot-fts-xapian dependency, when using dovecot community repository#2937

Merged
georglauterbach merged 2 commits intodocker-mailserver:masterfrom
casperklein:dovecot-fts-xapian_dependency
Dec 21, 2022
Merged

Fix dovecot-fts-xapian dependency, when using dovecot community repository#2937
georglauterbach merged 2 commits intodocker-mailserver:masterfrom
casperklein:dovecot-fts-xapian_dependency

Conversation

@casperklein
Copy link
Copy Markdown
Member

@casperklein casperklein commented Dec 18, 2022 •
edited
Loading

Description

The package dovecot-fts-xapian is installed from the debian repository.
Starting with version 1.4.9a-1+deb11u1, a new dependency was added: dovecot-abi-2.3.abiv13
dovecot-abi-2.3.abiv13 is a virtual package provided by dovecot-core (from the debian repository).
However dovecot-core from the community repository provides dovecot-abi-2.3.abiv19.

dovecot-fts-xapian changelog:

  * Generate dependency on dovecot ABI in use during build.
    Technique stolen from dovecot-antispam packaging.
    Thanks to Ron Lee <[email protected]> (Closes: #1009794)

This fix creates and installs an empty dummy package dovecot-abi-2.3.abiv13 to satisfy dovecot-fts-xapian while building the image, using the dovecot community repository.

Fixes #2935

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein added this to the v11.3.0 milestone Dec 18, 2022
@casperklein casperklein self-assigned this Dec 18, 2022
@casperklein casperklein marked this pull request as ready for review December 18, 2022 23:09
@casperklein casperklein requested a review from a team December 18, 2022 23:10
@georglauterbach georglauterbach added the meta/feature freeze On hold due to upcoming release process label Dec 18, 2022
@polarathene polarathene mentioned this pull request Dec 19, 2022
Merged
4 tasks
@georglauterbach georglauterbach removed the meta/feature freeze On hold due to upcoming release process label Dec 19, 2022
georglauterbach
georglauterbach approved these changes Dec 19, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is what dependency-limbo looks like :D

@georglauterbach georglauterbach mentioned this pull request Dec 19, 2022
Merged
5 tasks
@georglauterbach
Copy link
Copy Markdown
Member

georglauterbach commented Dec 21, 2022

I will go ahead and merge this now to release v11.3.1. @casperklein about the F2B PR: you said you wanted to review this again; does that mean, we need to open a new PR again for the F2B change? I actually see no reason and would just merge this on master again.. just asking here.

@georglauterbach georglauterbach merged commit b75fc44 into docker-mailserver:master Dec 21, 2022
@casperklein
Copy link
Copy Markdown
Member Author

casperklein commented Dec 22, 2022

does that mean, we need to open a new PR again for the F2B change? I actually see no reason

A PR is the right way to go. We have a policy to not directly committing to master, but instead doing reviews first. See #2944 for a reason why 😉

@casperklein casperklein deleted the dovecot-fts-xapian_dependency branch March 13, 2023 22:34
@polarathene polarathene mentioned this pull request Apr 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polarathene polarathene polarathene approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

@casperklein casperklein

Labels

area/scripts

Projects

None yet

Milestone

v11.3.0

Development

Successfully merging this pull request may close these issues.

[BUG] Building DMS fails with DOVECOT_COMMUNITY_REPO=1

3 participants

@casperklein @georglauterbach @polarathene