Skip to content

fix: Change the default OpenDMARC policy to reject#2933

Merged
polarathene merged 1 commit intodocker-mailserver:masterfrom
k3it:master
Dec 18, 2022
Merged

fix: Change the default OpenDMARC policy to reject#2933
polarathene merged 1 commit intodocker-mailserver:masterfrom
k3it:master

Conversation

@k3it
Copy link
Copy Markdown
Contributor

@k3it k3it commented Dec 13, 2022

fixes #2932

Description

Fixes #2932

Type of change

  • Improvement (non-breaking change that does improve existing functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@georglauterbach
Copy link
Copy Markdown
Member

georglauterbach commented Dec 13, 2022

Thank you very much for submitting this PR! We welcome people who contribute to DMS :) From my perspective, there is a bit more work involved here. I will provide a more detailed explanation in the issue you opened.

@georglauterbach georglauterbach added meta/feature freeze On hold due to upcoming release process meta/needs triage This issue / PR needs checks and verification from maintainers labels Dec 13, 2022
@georglauterbach georglauterbach added this to the v12.0.0 milestone Dec 13, 2022
@georglauterbach georglauterbach added kind/improvement Improve an existing feature, configuration file or the documentation area/configuration (file) service/security/dkim-dmarc-spf and removed meta/needs triage This issue / PR needs checks and verification from maintainers labels Dec 14, 2022
@georglauterbach georglauterbach changed the title Change opendmarc policy defalut to reject Change OpenDMARC policy default to reject Dec 14, 2022
@polarathene polarathene merged commit 7ec75ec into docker-mailserver:master Dec 18, 2022
polarathene added a commit that referenced this pull request Dec 18, 2022
@polarathene
Revert "fix: Change the default OpenDMARC policy to reject (#2933)"
f8c642b 
This reverts commit 7ec75ec.
@polarathene polarathene mentioned this pull request Dec 18, 2022
Closed
@polarathene polarathene changed the title Change OpenDMARC policy default to reject fix: Change the default OpenDMARC policy to reject Dec 18, 2022
@ap-wtioit ap-wtioit mentioned this pull request Feb 9, 2023
Closed
10 tasks
@groupmsl groupmsl mentioned this pull request Feb 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casperklein casperklein casperklein approved these changes

@polarathene polarathene polarathene approved these changes

@wernerfred wernerfred wernerfred approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

@k3it k3it

Labels

area/configuration (file) kind/improvement Improve an existing feature, configuration file or the documentation meta/feature freeze On hold due to upcoming release process service/security/dkim-dmarc-spf

Projects

None yet

Milestone

v12.0.0

Development

Successfully merging this pull request may close these issues.

emails with failing DMARC policy=reject are not rejected

5 participants

@k3it @georglauterbach @casperklein @polarathene @wernerfred