Skip to content

update: update to latest version of Fail2Ban#2903

Merged
georglauterbach merged 3 commits intomasterfrom
update_fail2ban
Dec 19, 2022
Merged

update: update to latest version of Fail2Ban#2903
georglauterbach merged 3 commits intomasterfrom
update_fail2ban

Conversation

@georglauterbach
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach commented Nov 16, 2022

Description

Tests pass locally; we just need to add a "fix". The new Fail2Ban configuration complains about allowipv6 not being set in the default configuration. Hence, I set it in a custom configuration. There is an additional description of this issue in the file itself. Other than that, all looks good.

This should actually not be a breaking change, hence marked for v11.3.

Type of change

  • Improvement (non-breaking change that does improve existing functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@georglauterbach
update to latest version of Fail2Ban
934a3fc 
Tests pass locally; we just need to add a "fix". The new Fail2Ban
configuration complains about `allowipv6` not being set in the default
configuration. Hence, I set it in a custom configuration. There is an
additional description of this issue in the file itself. Other than
that, all looks good.
@georglauterbach georglauterbach added area/security service/security/fail2ban area/features kind/update Update an existing feature, configuration file or the documentation labels Nov 16, 2022
@georglauterbach georglauterbach added this to the v11.3.0 milestone Nov 16, 2022
@georglauterbach georglauterbach self-assigned this Nov 16, 2022
@casperklein
Copy link
Copy Markdown
Member

casperklein commented Nov 16, 2022 •
edited
Loading

This should actually not be a breaking change, hence marked for v11.3.

F2B is bumped from 0.11.2 to 1.0.2. That's a major version upgrade. Also the changelog is quiet heavy. I haven't had time to read it completely, did you? Our tests are nice, but I doubt, they cover everything. So we should be really sure, it has no drawbacks before shipping it.

PR itself: LGTM.

@georglauterbach
Copy link
Copy Markdown
Member Author

georglauterbach commented Nov 17, 2022

This should actually not be a breaking change, hence marked for v11.3.

F2B is bumped from 0.11.2 to 1.0.2. That's a major version upgrade. Also the changelog is quiet heavy. I haven't had time to read it completely, did you?

Read through most of it :) Studied the "Compatibility" section in detail, looked good.

Our tests are nice, but I doubt, they cover everything. So we should be really sure, it has no drawbacks before shipping it.

We can wait with this and ship it with v12.

@georglauterbach georglauterbach modified the milestones: v11.3.0, v12.0.0 Nov 17, 2022
@github-actions github-actions Bot added the meta/stale This issue / PR has become stale and will be closed if there is no further activity label Dec 8, 2022
@georglauterbach georglauterbach added stale-bot/ignore Indicates that this issue / PR shall not be closed by our stale-checking CI and removed meta/stale This issue / PR has become stale and will be closed if there is no further activity labels Dec 8, 2022
@docker-mailserver docker-mailserver deleted a comment from github-actions Bot Dec 8, 2022
@georglauterbach georglauterbach removed the stale-bot/ignore Indicates that this issue / PR shall not be closed by our stale-checking CI label Dec 19, 2022
@georglauterbach georglauterbach merged commit 295d7f0 into master Dec 19, 2022
@georglauterbach georglauterbach deleted the update_fail2ban branch December 19, 2022 07:40
@casperklein casperklein mentioned this pull request Dec 19, 2022
Merged
4 tasks
georglauterbach added a commit that referenced this pull request Dec 19, 2022
@georglauterbach
Revert "update: update to latest version of Fail2Ban (#2903)"
6108b28 
This reverts commit 295d7f0.
@georglauterbach georglauterbach mentioned this pull request Dec 26, 2022
Merged
7 tasks
@georglauterbach georglauterbach mentioned this pull request Jan 5, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polarathene polarathene polarathene approved these changes

@wernerfred wernerfred wernerfred approved these changes

@casperklein casperklein Awaiting requested review from casperklein

Assignees

@georglauterbach georglauterbach

Labels

area/features area/security kind/update Update an existing feature, configuration file or the documentation service/security/fail2ban

Projects

None yet

Milestone

v12.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@georglauterbach @casperklein @polarathene @wernerfred