Skip to content

update: make the Dovecot community repository the default#2901

Merged
georglauterbach merged 2 commits intomasterfrom
dovecot_community_repo
Jan 2, 2023
Merged

update: make the Dovecot community repository the default#2901
georglauterbach merged 2 commits intomasterfrom
dovecot_community_repo

Conversation

@georglauterbach
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach commented Nov 16, 2022 •
edited
Loading

Description

This PR makes the Dovecot community repository the default, as it contains the latest version of Dovecot.

Not sure whether this can go into v11.3 or if it has to go into v12.

Type of change

  • Improvement (non-breaking change that does improve existing functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@georglauterbach georglauterbach added service/dovecot area/features kind/update Update an existing feature, configuration file or the documentation labels Nov 16, 2022
@georglauterbach georglauterbach self-assigned this Nov 16, 2022
@georglauterbach georglauterbach changed the title update: make the Dovecot community repositry the default update: make the Dovecot community repository the default Nov 16, 2022
polarathene
polarathene previously approved these changes Nov 16, 2022
View reviewed changes
@wernerfred
Copy link
Copy Markdown
Member

wernerfred commented Nov 16, 2022

Not sure whether this can go into v11.3 or if it has to go into v12.

v12 i would say as default behaviour changes without interaction

@casperklein
Copy link
Copy Markdown
Member

casperklein commented Nov 16, 2022

For the record:

Dovecot Community Version: 2.3.19
Dovecot Debian Version: 2.3.13

At the moment, there should only minor changes/fixes between those versions (but I haven't verified that).

On the other hand, there is no immediate need for this now, so postponing this to v12 should be fine?

@georglauterbach georglauterbach added this to the v12.0.0 milestone Nov 17, 2022
@georglauterbach
Copy link
Copy Markdown
Member Author

georglauterbach commented Nov 17, 2022

Marked it for v12. v11.3 release phase should begin soon.

@georglauterbach georglauterbach added the pr/waiting for other PR to get merged This PR is waiting for another / other PR(s) to get merged label Dec 19, 2022
@georglauterbach
Copy link
Copy Markdown
Member Author

georglauterbach commented Dec 19, 2022

currently waiting for #2937

@georglauterbach georglauterbach removed the pr/waiting for other PR to get merged This PR is waiting for another / other PR(s) to get merged label Dec 21, 2022
@georglauterbach
Copy link
Copy Markdown
Member Author

georglauterbach commented Dec 23, 2022 •
edited
Loading

I will resolve conflicts. We can then merge this PRs that go into v12, so this should be good to go I guess :) @casperklein

@casperklein
Copy link
Copy Markdown
Member

casperklein commented Dec 23, 2022

@georglauterbach We could just set ARG DOVECOT_COMMUNITY_REPO=1. So in case there are any issues for someone, switching back is easy. The final code removal could be done in a later release.

@georglauterbach
Copy link
Copy Markdown
Member Author

georglauterbach commented Dec 23, 2022 •
edited
Loading

@georglauterbach We could just set ARG DOVECOT_COMMUNITY_REPO=1. So in case there are any issues for someone, switching back is easy. The final code removal could be done in a later release.

Okay, I will adjust the PR.

EDIT: Done.

@georglauterbach georglauterbach mentioned this pull request Jan 1, 2023
Merged
7 tasks
@georglauterbach
Copy link
Copy Markdown
Member Author

georglauterbach commented Jan 1, 2023

ping @polarathene :)

@georglauterbach georglauterbach merged commit 1fd407b into master Jan 2, 2023
@georglauterbach georglauterbach deleted the dovecot_community_repo branch January 2, 2023 12:25
@polarathene polarathene mentioned this pull request Nov 19, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casperklein casperklein casperklein approved these changes

@polarathene polarathene polarathene approved these changes

Assignees

@georglauterbach georglauterbach

Labels

area/features kind/update Update an existing feature, configuration file or the documentation service/dovecot

Projects

None yet

Milestone

v12.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@georglauterbach @wernerfred @casperklein @polarathene