Skip to content

ci: update to new output format on GH actions#2892

Merged
georglauterbach merged 3 commits intomasterfrom
gh/update-workflows
Nov 7, 2022
Merged

ci: update to new output format on GH actions#2892
georglauterbach merged 3 commits intomasterfrom
gh/update-workflows

Conversation

@georglauterbach
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach commented Nov 5, 2022 •
edited
Loading

Description

See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Type of change

  • Update to component due to deprecation notice

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@georglauterbach georglauterbach added area/ci kind/update Update an existing feature, configuration file or the documentation labels Nov 5, 2022
@georglauterbach georglauterbach added this to the v11.3.0 milestone Nov 5, 2022
@georglauterbach georglauterbach self-assigned this Nov 5, 2022
@casperklein
Copy link
Copy Markdown
Member

casperklein commented Nov 5, 2022

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works

Are you sure? 😄

@georglauterbach
Copy link
Copy Markdown
Member Author

georglauterbach commented Nov 5, 2022

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works

Are you sure? smile

Not sure I follow, haha :D What did I miss?:)

@casperklein
Copy link
Copy Markdown
Member

casperklein commented Nov 5, 2022

I have made corresponding changes to the documentation

You did not make changes to the docs for example ;-)

@georglauterbach
Copy link
Copy Markdown
Member Author

georglauterbach commented Nov 6, 2022

I have made corresponding changes to the documentation

You did not make changes to the docs for example ;-)

I always read this like "if there changes to the docs necessary, I did them" 🙈 I can adjust the description though 🙃

@georglauterbach georglauterbach merged commit 2bc4078 into master Nov 7, 2022
@georglauterbach georglauterbach deleted the gh/update-workflows branch November 7, 2022 08:31
polarathene pushed a commit that referenced this pull request Nov 26, 2022
@georglauterbach @polarathene
ci: update to new output format on GH actions (#2892)
cdeabcb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casperklein casperklein casperklein approved these changes

@polarathene polarathene polarathene approved these changes

Assignees

@georglauterbach georglauterbach

Labels

area/ci kind/update Update an existing feature, configuration file or the documentation

Projects

None yet

Milestone

v11.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@georglauterbach @casperklein @polarathene