Skip to content

release: v11.3.0#2882

Merged
georglauterbach merged 5 commits intomasterfrom
next-release
Dec 19, 2022
Merged

release: v11.3.0#2882
georglauterbach merged 5 commits intomasterfrom
next-release

Conversation

@casperklein
Copy link
Copy Markdown
Member

@casperklein casperklein commented Nov 1, 2022

Description

This PR marks the feature freeze phase for the v11.3.0 release.

The current :edge image will be tested for roughly one week and if no bugs get reported, v11.3.0 will be released. During this testing period, only PRs that do not change functionality will be merged.

If you want to support us, give the latest :edge image a try and report any issues you encounter back to this PR.

Documentation updates may be merged. Feature freeze is in place until 18 Dec 2022.

Type of change

  • Release

Release-Checklist:

  • Update CHANGELOG.md
  • Update version in VERSION
  • Draft release

@casperklein casperklein added the kind/release This PR marks a release label Nov 1, 2022
@github-actions github-actions Bot added the meta/stale This issue / PR has become stale and will be closed if there is no further activity label Nov 21, 2022
@wernerfred wernerfred added stale-bot/ignore Indicates that this issue / PR shall not be closed by our stale-checking CI and removed meta/stale This issue / PR has become stale and will be closed if there is no further activity labels Nov 21, 2022
@docker-mailserver docker-mailserver deleted a comment from github-actions Bot Nov 21, 2022
@georglauterbach georglauterbach marked this pull request as ready for review December 11, 2022 09:39
@georglauterbach georglauterbach changed the title release: vX.X.X release: v11.3.0 Dec 11, 2022
@georglauterbach georglauterbach added this to the v11.3.0 milestone Dec 11, 2022
@georglauterbach georglauterbach self-assigned this Dec 11, 2022
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running the latest :edge now for a prolonged period, seems good to me.

@georglauterbach
Copy link
Copy Markdown
Member

Alright, let's finish this up @docker-mailserver/maintainers

@casperklein
Copy link
Copy Markdown
Member Author

No general issues in my setup. However, building with dovecot community repo is broken for some days now. I am going to provide a fix tonight/tomorrow.

@polarathene
Copy link
Copy Markdown
Member

A PR was accidentally merged early by me and should be reverted.


Did we want to include in the ChangeLog and release notes the pinned deprecation notices?:

@georglauterbach
Copy link
Copy Markdown
Member

@polarathene please add the notice to the Changelog. We can then merge this.

@polarathene
Copy link
Copy Markdown
Member

polarathene commented Dec 18, 2022

  • Updated the draft release and this PR changelog to include the deprecation notices 👍
  • Rebased this PR onto current master.
  • Updated changelog and draft release to include mention of the opendmarc config fix I recently merged.

Is #2937 also getting squeezed into 11.3?

@georglauterbach
Copy link
Copy Markdown
Member

Is #2937 also getting squeezed into 11.3?

No, this would be too big of a change :) I will go ahead and release v11.3 now.

@georglauterbach georglauterbach merged commit 50257b4 into master Dec 19, 2022
@georglauterbach georglauterbach deleted the next-release branch December 19, 2022 06:39
@casperklein
Copy link
Copy Markdown
Member Author

Is #2937 also getting squeezed into 11.3?

No, this would be too big of a change :) I will go ahead and release v11.3 now.

Big change? This is a small fix for a currently broken build. IMO this should have been merged before, that's why I labeled it accordingly.

Now a version was released, that cannot be build with the dovecot community repo enabled. That makes it hard(er) to test, before making it the default in the next version..

@georglauterbach
Copy link
Copy Markdown
Member

Big change? This is a small fix for a currently broken build. IMO this should have been merged before, that's why I labeled it accordingly.

A no-issue IMO because a custom build is broken, not the one used to build v11.3. Now, you cannot build the custom image on the v11.3 tag, I see and I agree, not nice. But also not a dealbreaker. If we had chosen to merge this, I would have requested another feature freeze.

So, my proposal: why don't we just release a patch for this? For example v11.3.1? I can revert the Fail2Ban PR if wo choose to go this route.

Now a version was released, that cannot be build with the dovecot community repo enabled. That makes it hard(er) to test, before making it the default in the next version..

Should not affect testing as we have enough tests running (through PRs) before we release v12.

@casperklein
Copy link
Copy Markdown
Member Author

If we had chosen to merge this, I would have requested another feature freeze.

In that special case, I don't think that should be necessary, as it only fixed the building (with dovecot repo), not running DMS. But even if we did so, what's wrong with that? We don't have any urge to release a new version 🤷

I can revert the Fail2Ban PR

Yes please. I haven't time yet to test and finally approve it. My personal deadline for this is mid January, but hopefully earlier.

My proposal: Releasing 11.3.1 with the following changes:

@georglauterbach
Copy link
Copy Markdown
Member

@casperklein you can now merge #2937 (I cannot update the branch ref since it is in your repository, not DMS; hence, I cannot merge). Please also prepare the PR for the release. No feature freeze required this time.

@georglauterbach
Copy link
Copy Markdown
Member

If we had chosen to merge this, I would have requested another feature freeze.

In that special case, I don't think that should be necessary, as it only fixed the building (with dovecot repo), not running DMS. But even if we did so, what's wrong with that? We don't have any urge to release a new version shrug

I wanted to have this done so I can use the latest edge with the new F2B. So, no, there is no urge, but there is also no reason to prolong the time span unnecessarily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/release This PR marks a release stale-bot/ignore Indicates that this issue / PR shall not be closed by our stale-checking CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants