Skip to content

Bugfix: './setup.sh email list' does not display aliases correctly#2881

Merged
casperklein merged 7 commits intodocker-mailserver:masterfrom
casperklein:listmailuser-fix-2877
Nov 4, 2022
Merged

Bugfix: './setup.sh email list' does not display aliases correctly#2881
casperklein merged 7 commits intodocker-mailserver:masterfrom
casperklein:listmailuser-fix-2877

Conversation

@casperklein
Copy link
Copy Markdown
Member

@casperklein casperklein commented Nov 1, 2022 •
edited
Loading

Description

Details see here.

Before:

./setup.sh email list
* [email protected]
    [ aliases -> [email protected] ]

* [email protected]
    [ aliases -> [email protected] ]

After:

./setup.sh email list
* [email protected]

* [email protected]
    [ aliases -> [email protected] ]

Fixes #2877

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein added this to the v11.3.0 milestone Nov 1, 2022
@casperklein casperklein self-assigned this Nov 1, 2022
@casperklein casperklein marked this pull request as ready for review November 1, 2022 00:57
georglauterbach
georglauterbach previously approved these changes Nov 1, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

polarathene
polarathene requested changes Nov 2, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exchanges one bug for another.

  • Bring back conditional check.
  • Improve the pattern for grep on ${MAIL_ACCOUNT} that matches the supported bounds (prefix / suffix).

Comment thread target/bin/listmailuser
Comment thread target/bin/listmailuser Outdated
polarathene
polarathene approved these changes Nov 4, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic improvement thanks! 🥳

@casperklein casperklein merged commit 69aef2e into docker-mailserver:master Nov 4, 2022
@casperklein casperklein deleted the listmailuser-fix-2877 branch November 4, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polarathene polarathene polarathene approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

@casperklein casperklein

Labels

area/scripts

Projects

None yet

Milestone

v11.3.0

Development

Successfully merging this pull request may close these issues.

[BUG] './setup.sh email list' does not display aliases correctly

3 participants

@casperklein @polarathene @georglauterbach