Skip to content

setup.sh: Remove __err function#2876

Merged
casperklein merged 2 commits intomasterfrom
casperklein-patch-1
Oct 31, 2022
Merged

setup.sh: Remove __err function#2876
casperklein merged 2 commits intomasterfrom
casperklein-patch-1

Conversation

@casperklein
Copy link
Copy Markdown
Member

@casperklein casperklein commented Oct 30, 2022

Description

This bugs me already for a while. "Unchecked error" is triggered on all errors, also on those that are expected. I think it's fine to remove this completely. setup.sh is not that large, that we need such a kind of debug function IMO.

# ./setup.sh alias list
[  ERROR  ]  '/tmp/docker-mailserver/postfix-virtual.cf' does not exist
[  ERROR  ]  Aborting

--- UNCHECKED ERROR
  - script    = ./setup.sh
  - function  = _run_in_new_container
  - command   = ${CRI} run --rm "${USE_TTY}" -v "${CONFIG_PATH}:${DMS_CONFIG}${USE_SELINUX}" "${IMAGE_NAME}" "${@}"
  - line      = 147
  - exit code = 1

This should not have happened. Please file a bug report.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein requested a review from a team October 30, 2022 22:40
@casperklein casperklein marked this pull request as ready for review October 30, 2022 22:40
@casperklein casperklein merged commit e32a530 into master Oct 31, 2022
@casperklein casperklein deleted the casperklein-patch-1 branch October 31, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants