scripts: Improve error handling, when parameters are missing#2854
Merged
casperklein merged 13 commits intodocker-mailserver:masterfrom Oct 29, 2022
Merged
scripts: Improve error handling, when parameters are missing#2854casperklein merged 13 commits intodocker-mailserver:masterfrom
casperklein merged 13 commits intodocker-mailserver:masterfrom
Conversation
7 tasks
12 tasks
polarathene
previously approved these changes
Oct 23, 2022
georglauterbach
previously approved these changes
Oct 23, 2022
1eae0ed
georglauterbach
previously approved these changes
Oct 23, 2022
polarathene
previously approved these changes
Oct 24, 2022
4f2c92c
polarathene
previously approved these changes
Oct 25, 2022
georglauterbach
previously approved these changes
Oct 25, 2022
polarathene
previously approved these changes
Oct 26, 2022
Member
polarathene
left a comment
There was a problem hiding this comment.
Awesome 🎉
I will point out that while in the review page I see a few other files that could throw in:
_require_n_parameters_or_print_usage 1 "${@}"Like excluderelaydomain and setquota, both still have the existing help handling and could be consistent with the other files changed here, but not too fussed either way 😅
1935bb0
Member
Author
Consistency FTW 🚀 You know, that I am not a fan of "get this merged" and providing a follow up in such cases 😆 Therefore: 1935bb0 |
georglauterbach
approved these changes
Oct 27, 2022
polarathene
approved these changes
Oct 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When parameters are missing (alias destination in that case), this error is shown:
This PR solves that, by showing the usage instead.
Type of change
Checklist:
docs/)