Skip to content

Follow up for #2849#2853

Merged
casperklein merged 3 commits intodocker-mailserver:masterfrom
casperklein:more-fixes-2849
Oct 23, 2022
Merged

Follow up for #2849#2853
casperklein merged 3 commits intodocker-mailserver:masterfrom
casperklein:more-fixes-2849

Conversation

@casperklein
Copy link
Copy Markdown
Member

@casperklein casperklein commented Oct 22, 2022

Description

There were some $2 left, that were not correctly handled when empty.

This PR fixes this and also simplify/streamline the code a bit.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein requested a review from a team October 22, 2022 21:00
@casperklein casperklein marked this pull request as ready for review October 22, 2022 21:00
@casperklein casperklein merged commit c4df9c1 into docker-mailserver:master Oct 23, 2022
@casperklein casperklein deleted the more-fixes-2849 branch October 23, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants