Skip to content

Fix: Make fetchmail data persistant#2851

Merged
casperklein merged 2 commits intodocker-mailserver:masterfrom
casperklein:fix-fetchmail-forgets-ids-after-docker-update-2832
Oct 23, 2022
Merged

Fix: Make fetchmail data persistant#2851
casperklein merged 2 commits intodocker-mailserver:masterfrom
casperklein:fix-fetchmail-forgets-ids-after-docker-update-2832

Conversation

@casperklein
Copy link
Copy Markdown
Member

@casperklein casperklein commented Oct 22, 2022 •
edited
Loading

Description

Fixes #2832

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein self-assigned this Oct 22, 2022
@casperklein casperklein added this to the v11.3.0 milestone Oct 22, 2022
@casperklein casperklein requested review from a team and polarathene and removed request for polarathene October 22, 2022 16:29
@casperklein casperklein marked this pull request as ready for review October 22, 2022 16:29
@casperklein
Copy link
Copy Markdown
Member Author

casperklein commented Oct 22, 2022

@docker-mailserver/maintainers

Can you imagine a reason, why someone would want ONE_DIR=0? We made ONE_DIR=1 the default. I was wondering, if we should get rid of ONE_DIR entirely in the next major release.

@polarathene
Copy link
Copy Markdown
Member

polarathene commented Oct 22, 2022

Can you imagine a reason, why someone would want ONE_DIR=0? We made ONE_DIR=1 the default. I was wondering, if we should get rid of ONE_DIR entirely in the next major release.

ONE_DIR=1 seems convenient for both bind mounts and data container mounts. Not sure when ONE_DIR=0 would be useful, with ONE_DIR=1 we have a clear place for anything worth persisting to be.

I'm fine with dropping ONE_DIR in favor of always assuming ONE_DIR=1 👍

@casperklein casperklein merged commit 474eb50 into docker-mailserver:master Oct 23, 2022
@casperklein casperklein deleted the fix-fetchmail-forgets-ids-after-docker-update-2832 branch October 23, 2022 01:12
@casperklein casperklein mentioned this pull request Apr 9, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polarathene polarathene polarathene approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

@casperklein casperklein

Labels

area/scripts

Projects

None yet

Milestone

v11.3.0

Development

Successfully merging this pull request may close these issues.

[BUG] Fetchmail forget's id's after recreating DMS container

3 participants

@casperklein @polarathene @georglauterbach