Skip to content

Remove unusual space from shebang line#2834

Merged
casperklein merged 2 commits intodocker-mailserver:masterfrom
casperklein:she-bang
Oct 17, 2022
Merged

Remove unusual space from shebang line#2834
casperklein merged 2 commits intodocker-mailserver:masterfrom
casperklein:she-bang

Conversation

@casperklein
Copy link
Copy Markdown
Member

@casperklein casperklein commented Oct 16, 2022 •
edited
Loading

Description

We should stick to "global standards", where the shebang line does not include a space.
The space is absolutely valid, but not widespread used and might look weird to someone new to this project.

Let's discuss.. and merge or withdraw this PR.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein requested a review from a team October 16, 2022 11:33
@casperklein casperklein self-assigned this Oct 16, 2022
@georglauterbach
Copy link
Copy Markdown
Member

georglauterbach commented Oct 16, 2022

I'm used to the space, but I don't really care, as long as we do it consistently:) This PR does it consistently, so all is well.

@casperklein
Copy link
Copy Markdown
Member Author

casperklein commented Oct 16, 2022

I've to admit, that I learned to like it also over the time 😆 But I prefer, that all (my) scripts try to follow the same standards.

@georglauterbach
Copy link
Copy Markdown
Member

georglauterbach commented Oct 16, 2022

I've to admit, that I learned to like it also over the time 😆 But I prefer, that all (my) scripts try to follow the same standards.

I have all my script written with the space 🙈 But this is fine anyway :)

@polarathene
Copy link
Copy Markdown
Member

polarathene commented Oct 17, 2022

But I prefer, that all (my) scripts try to follow the same standards.

I'm going to take a wild guess that it'd be more consistent (less files to change) if we kept the space instead for this project 😛

I too prefer the space, and I doubt anyone coming to contribute is going to be tripped up by this concern, I certainly wasn't when I became a contributor and started working with shell scripts (learned most of that from this project and you two! ❤️ ).

Likewise, I do not care either way what the project uses, just that we're consistent 👍

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 17, 2022

Documentation preview for this PR is ready! 🎉

Built with commit: b785b54

@casperklein casperklein merged commit a930aeb into docker-mailserver:master Oct 17, 2022
@casperklein casperklein deleted the she-bang branch October 17, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polarathene polarathene polarathene approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

@casperklein casperklein

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@casperklein @georglauterbach @polarathene