Skip to content

fail2ban: enable network bans#2818

Merged
casperklein merged 7 commits intodocker-mailserver:masterfrom
casperklein:fail2ban-enable-network-bans
Oct 15, 2022
Merged

fail2ban: enable network bans#2818
casperklein merged 7 commits intodocker-mailserver:masterfrom
casperklein:fail2ban-enable-network-bans

Conversation

@casperklein
Copy link
Copy Markdown
Member

@casperklein casperklein commented Oct 9, 2022 •
edited
Loading

Description

Fixes #2669

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein added area/ci service/security/fail2ban kind/improvement Improve an existing feature, configuration file or the documentation meta/feature freeze On hold due to upcoming release process labels Oct 9, 2022
@casperklein casperklein added this to the v11.3.0 milestone Oct 9, 2022
@casperklein casperklein requested a review from a team October 9, 2022 01:04
@casperklein casperklein self-assigned this Oct 9, 2022
polarathene
polarathene previously approved these changes Oct 9, 2022
View reviewed changes
@georglauterbach
Copy link
Copy Markdown
Member

georglauterbach commented Oct 9, 2022

When we update to the latest F2B version in the near future, is this still relevant? I was about to update F2B, and was curious.

@casperklein
Copy link
Copy Markdown
Member Author

casperklein commented Oct 9, 2022 •
edited
Loading

This feature is not implemented upstream yet. There is still an open issue about that.

When the new f2b version came out, I tried it, however lots of f2b tests failed. I fear it's not an drop-in replacement for the current version and might require some adjustments and testing.

@georglauterbach
Copy link
Copy Markdown
Member

georglauterbach commented Oct 9, 2022

This feature is not implemented upstream yet. There is still an open issue about that.

When the new f2b version came out, I tried it, however lots of f2b tests failed. I fear it's not an drop-in replacement for the current version and might require some adjustments and testing.

Understood :)

georglauterbach
georglauterbach previously approved these changes Oct 9, 2022
View reviewed changes
@georglauterbach georglauterbach removed the meta/feature freeze On hold due to upcoming release process label Oct 13, 2022
polarathene
polarathene previously approved these changes Oct 14, 2022
View reviewed changes
@casperklein casperklein marked this pull request as ready for review October 14, 2022 23:17
@casperklein casperklein enabled auto-merge (squash) October 14, 2022 23:17
@casperklein casperklein merged commit 032ed00 into docker-mailserver:master Oct 15, 2022
@casperklein casperklein deleted the fail2ban-enable-network-bans branch October 15, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polarathene polarathene polarathene approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

@casperklein casperklein

Labels

area/ci kind/improvement Improve an existing feature, configuration file or the documentation service/security/fail2ban

Projects

None yet

Milestone

v11.3.0

Development

Successfully merging this pull request may close these issues.

[BUG] Fail2ban not blocking ip ranges when captured as a custom ban

3 participants

@casperklein @georglauterbach @polarathene