tests: Wait until container is not in starting state anymore, before running health check#2810
Merged
casperklein merged 3 commits intomasterfrom Oct 2, 2022
Merged
tests: Wait until container is not in starting state anymore, before running health check#2810casperklein merged 3 commits intomasterfrom
casperklein merged 3 commits intomasterfrom
Conversation
It seams, that Docker does not start a container immediately, after successful running the `docker run..` command. Therefor the 30 seconds wait time for the health test can be to low. Hopefully, adding three more seconds solve that issue.
georglauterbach
previously approved these changes
Oct 2, 2022
Member
georglauterbach
left a comment
There was a problem hiding this comment.
While not pretty, I hope this does the job :)
Member
Author
I decided for another approach, which hopefully will be bullet proof now. |
georglauterbach
approved these changes
Oct 2, 2022
Member
georglauterbach
left a comment
There was a problem hiding this comment.
Indeed, much better - LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It seams, that Docker does not start a container immediately, after successfully running the
docker run..command. Therefor the 30 seconds wait time for the health test can be to low.Hopefully, adding three more seconds solve that issue.Fixes: https://github.com/docker-mailserver/docker-mailserver/actions/runs/3162276455/jobs/5148743130#step:5:227
This fix now waits, until docker itself reports, that the container is not in the starting state anymore.
Type of change
Checklist:
docs/)