Partial review as the browser crashed, but this was salvaged thankfully.

Remainder of review completed 😀

I used this online crontab tool, which should link to an example of every 29th minute. You'll see that it's only within an hour, then it resets. So every 50th minute would be always at 50 minutes past the current hour, technically every hour at that point.. same with every 31 minutes. (EDIT: For clarity, look at the lines above the input that shows the scheduled times when the duration does not divide an hour evenly)

Thus I think the actual max is 30? (Every 30 minutes) Otherwise it's effectively hourly from then on, and anything after 60 likewise ends up being every hour (just with no offset).

I don't know cron that well, the other maintainers can provide feedback on that.

I'm going to batch commit the suggestions, so only the remaining feedback after (3 items left) that needs to be addressed 👍

• su -s decision deferred to another reviewer.
• xoauth docs link.
• Adding tests (once everything else is approved).

Looks very good, just some minor stylistic issues. I hope you can just batch-commit my suggestions :)

From a scripts perspective, LGTM. I hope all tests pass now :)

I will batch commit these changes.

Fixes some typos, and uses permalinks instead of referencing lines on the master branch which is not a stable reference we can rely on.

We still may want to consider tests.

If I understand this feature correctly. We could test it by having two DMS containers running, and treating one of them as the remote mail-server (the role of gmail for example)?

Additionally, here is the getmail6 bats test file that uses DMS to handle it's testing. I haven't looked through it properly yet.

Looks good to me now :) Maybe @casperklein want to have another look at this as well, and I think there is one comment from him that should also be resolved. But overall, nice work 🚀

Just some small change requests. Otherwise ready to merge.