Skip to content

docs: add note about Docker version when building#2799

Merged
georglauterbach merged 5 commits intomasterfrom
doc/docker
Sep 28, 2022
Merged

docs: add note about Docker version when building#2799
georglauterbach merged 5 commits intomasterfrom
doc/docker

Conversation

@georglauterbach
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach commented Sep 26, 2022

Description

See #2791. Adds a note that we require a recent version of Docker when building.

Type of change

  • Improvement (non-breaking change that does improve existing functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@georglauterbach georglauterbach added kind/improvement Improve an existing feature, configuration file or the documentation area/documentation labels Sep 26, 2022
@georglauterbach georglauterbach added this to the v11.2.0 milestone Sep 26, 2022
@georglauterbach georglauterbach requested a review from a team September 26, 2022 09:39
@georglauterbach georglauterbach self-assigned this Sep 26, 2022
@casperklein
Copy link
Copy Markdown
Member

casperklein commented Sep 26, 2022

The mentioned issue was not due the Docker version, but the non usage of DOCKER_BUILDKIT=1 while building.

@georglauterbach
Copy link
Copy Markdown
Member Author

georglauterbach commented Sep 26, 2022

The mentioned issue was not due the Docker version, but the non usage of DOCKER_BUILDKIT=1 while building.

The initial issue suggested otherwise. Regardless, I think this addition is well worth it :) We could add the note about DOCKER_BUILDKIT=1 as well!

casperklein
casperklein reviewed Sep 26, 2022
View reviewed changes
Comment thread docs/content/examples/tutorials/docker-build.md Outdated
@georglauterbach georglauterbach requested review from a team and casperklein September 27, 2022 07:57
@georglauterbach georglauterbach requested a review from a team September 27, 2022 09:35
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 28, 2022

Documentation preview for this PR is ready! 🎉

Built with commit: bf4535f

@georglauterbach georglauterbach merged commit 98279e5 into master Sep 28, 2022
@georglauterbach georglauterbach deleted the doc/docker branch September 28, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casperklein casperklein casperklein approved these changes

@wernerfred wernerfred wernerfred approved these changes

Assignees

@georglauterbach georglauterbach

Labels

area/documentation kind/improvement Improve an existing feature, configuration file or the documentation

Projects

None yet

Milestone

v11.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@georglauterbach @casperklein @wernerfred