Add ability to build with Dovecot community repository#2797
Add ability to build with Dovecot community repository#2797casperklein merged 5 commits intodocker-mailserver:masterfrom
Conversation
|
Looks good - one question though: as with F2B, is there a special reason to not use the community repository all the time? The comfort of choosing whether to build with the Repo is very nice, I won't block merging, but it seems a bit unnecessary to me :) |
It's just to avoid the minimal chance of issues fo existing setups. Therefore my proposal was, to make it now optional and later the default. We could also switch right now. I am using the community repo for a long time and had never issues. |
I would go with postponing merging this until after the release of v11.2.0 and then just use the community repo for all builds :) But I am completely fine with your proposal too. What do other @docker-mailserver/maintainers say? |
|
I would prefer merging this, as it has no drawbacks, but gives easily the ability to test the community version right now. Later it's pretty simple to remove the condition and make it the default. |
Very much fine with me :D One last question: this PR includes changes from the currently open F2B PR right, so we merge the F2B PR beforehand? |
|
Yeah, I've created a new branch based on the f2b branch. That's why f2b commits also show up here. f2b should be merged first. |
|
Same old issue with CI: only 217 tests are executed because |
|
Shouldn't the changes be added to |
They should (in theory), but as the new changelog format has not been merged yet, I think it's fine for the follow-up PR that enabled the community Repo by default to add a changelog notice. |
On the 4th attempt, the tests run successful 🎉 |
Description
This PR adds the ability, to use the latest Dovecot packages from the community repository. For this, the build argument
DOVECOT_COMMUNITY_REPO=1must be used.The current version for Dovecot in the debian repository is
2.3.13. In the community repository it is2.3.19.1.There shouldn't be any problems for existing setups switching to the community repository, as the version gap is only minor. However to be safe, we can wait for the next DMS major release, to make the community repository the default.
Type of change
Checklist:
docs/)