Skip to content

release: v11.2.0#2790

Merged
georglauterbach merged 3 commits intomasterfrom
release/v11.2.0
Oct 13, 2022
Merged

release: v11.2.0#2790
georglauterbach merged 3 commits intomasterfrom
release/v11.2.0

Conversation

@georglauterbach
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach commented Sep 21, 2022 •
edited
Loading

Description

I know, this is a release PR, but:

I introduced the "Keep a Changelog"-format which helps me in not spending this much time on changelogs in the future. There is a another PR (#2789) that will update the documentation before v11.2.0 is released, which focuses on adding the entry to the changelog before merging a relevant PR.

Releasing is always a huge efforts when I am writing the changelog because of the many manual adjustments. This is unacceptable and needs to change. The format change is the solution I think.

I already prepared a draft for v11.2.0, have a look :D

Currently waiting on:

Feature freeze is now in place until 12 Oct 2022.

Type of change

  • Release

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@georglauterbach
update ´VERSION and CHANGELOG.md`
a6f3261 
I introduced the "Keep a Changelog"-format which helps me in **not**
spending this much time on changelogs in the future. There is a another
PR that will update the documentation before v11.2.0 is released, which
focuses on adding the entry to the changelog before merging a relevant
PR.

Releasing is always a huge efforts when I get the changelog and adjus
it. This is incceptable and needs to change. This is the solution.
@georglauterbach georglauterbach added priority/high kind/release This PR marks a release pr/waiting for other PR to get merged This PR is waiting for another / other PR(s) to get merged labels Sep 21, 2022
@georglauterbach georglauterbach added this to the v11.2.0 milestone Sep 21, 2022
@georglauterbach georglauterbach self-assigned this Sep 21, 2022
wernerfred
wernerfred approved these changes Sep 21, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@wernerfred wernerfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! Writing the release information was always a manual nightmare.
Just curious: what speaks against taking the release notes that github can autogenerate for the changelog? It is not that structured but i like the fact that every change is included (even if very small) and every change is linked to its PR.

@georglauterbach
Copy link
Copy Markdown
Member Author

georglauterbach commented Sep 21, 2022

I like it! Writing the release information was always a manual nightmare.

Indeed 🙏🏼

Just curious: what speaks against taking the release notes that github can autogenerate for the changelog? It is not that structured but i like the fact that every change is included (even if very small) and every change is linked to its PR.

Nothing really, but I like the way that "Keep a Changelog" structures the information. I decided against just copying, because

  1. I would put the (automatically generated) list of all PRs into the Releases page so no information is lost
  2. Have the CHANGELOG.md show information in a nice, structured way

@georglauterbach georglauterbach mentioned this pull request Sep 21, 2022
Merged
7 tasks
@georglauterbach
Copy link
Copy Markdown
Member Author

georglauterbach commented Sep 21, 2022

NICE UPDATE: Take a look at the latest manual run I started: https://github.com/docker-mailserver/docker-mailserver/actions/runs/3100146489

Image build time is 1:15 min :D Nice! Caches and generic workflows seem to work! 🙌🏼

@georglauterbach
Copy link
Copy Markdown
Member Author

georglauterbach commented Sep 24, 2022

@casperklein feel free to bring up your PR about the F2B/Dovecot packages - no time pressure with this release.

@georglauterbach
Copy link
Copy Markdown
Member Author

georglauterbach commented Oct 4, 2022

@casperklein do you want to merge #2808 before we do the freeze & release this?

@georglauterbach georglauterbach removed the pr/waiting for other PR to get merged This PR is waiting for another / other PR(s) to get merged label Oct 5, 2022
@georglauterbach
Copy link
Copy Markdown
Member Author

georglauterbach commented Oct 5, 2022

Alright, feature-freeze is in-place.

casperklein
casperklein reviewed Oct 10, 2022
View reviewed changes
Comment thread CHANGELOG.md
casperklein
casperklein approved these changes Oct 11, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@casperklein casperklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues in my setup 👍

@georglauterbach
Copy link
Copy Markdown
Member Author

georglauterbach commented Oct 12, 2022

No issues in my setup +1

Neither on mine :D

@georglauterbach georglauterbach merged commit 4bae8eb into master Oct 13, 2022
@georglauterbach georglauterbach deleted the release/v11.2.0 branch October 13, 2022 08:58
@casperklein casperklein mentioned this pull request Oct 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casperklein casperklein casperklein approved these changes

@wernerfred wernerfred wernerfred approved these changes

@polarathene polarathene Awaiting requested review from polarathene

Assignees

@georglauterbach georglauterbach

Labels

kind/release This PR marks a release priority/high

Projects

None yet

Milestone

v11.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@georglauterbach @casperklein @polarathene @wernerfred