tests: Wait at least 30 seconds before checking the health state of the container#2777
Merged
casperklein merged 4 commits intodocker-mailserver:masterfrom Sep 19, 2022
Conversation
polarathene
approved these changes
Sep 18, 2022
Member
polarathene
left a comment
There was a problem hiding this comment.
An alternative might be to shift the test to the end of the file (but should keep the note about 30 sec requirement), or moving to a separate test file.
Member
Author
I thought about this also, but that would at 30 seconds to the overall test run time. The solution I provided added max 1-2 seconds in my tests and ensures, that the test succeed. I prefer this solution, as it is bullet proof. Moving the test more to the bottom could help, but might fail in the future again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes failed health-checks like this, when the CI is faster than 30 seconds when running the health check (container isn't healthy yet at this point --> first health check is run after 30 seconds):
Type of change
Checklist:
docs/)